Bug 225771 - [icmp] members of icmpstat are still u_long, why not uint64_t?
Summary: [icmp] members of icmpstat are still u_long, why not uint64_t?
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-net mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-02-08 20:39 UTC by Kun Xie
Modified: 2018-02-09 04:06 UTC (History)
0 users

See Also:


Attachments
replace u_long to uint64_t in icmpstat (1.77 KB, patch)
2018-02-08 20:39 UTC, Kun Xie
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kun Xie 2018-02-08 20:39:46 UTC
Created attachment 190441 [details]
replace u_long to uint64_t in icmpstat

r253081 changed all fields of many stat structures to uint64_t to adapt with the PCPU counters, but icmpstat's all fields are still u_long. And then r253084 migrate many structs including icmpstat to PCPU.

There is no error while building it because the number of the fields is even, so it might be forgotten, but if a new u_long field is added into the struct, then there will be an build error.

A patch to change all fields to uint64_t is attached.