Bug 225844 - Corsair K70 RGB Keyboard does not work
Summary: Corsair K70 RGB Keyboard does not work
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: 11.1-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: Hans Petter Selasky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-12 03:57 UTC by tom@tomdignan.com
Modified: 2019-03-25 13:58 UTC (History)
1 user (show)

See Also:
koobs: mfc-stable11+
koobs: mfc-stable10+

Attachments
Corsair K70 RGB Keyboard Patch (1.11 KB, patch)
2018-02-13 02:40 UTC, tom@tomdignan.com 		no flags Details | Diff
Corsair K70 RGB Keyboard Patch(11.1-RELEASE) (1.16 KB, patch)
2018-02-13 02:41 UTC, tom@tomdignan.com 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tom@tomdignan.com 2018-02-12 03:57:04 UTC 
Similar to this bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193279 my Corsair keyboard would not work. The difference is that this one is a Corsair K70 "RGB" keyboard. It is a slightly different model, and has a different productId: 0x1b13.

I was able to fix it by adding the line 

hw.usb.quirk.0="0x1b1c 0x1b13 0 0xffff UQ_KBD_BOOTPROTO"

to /boot/loader.conf.

I imagine it can be fixed in the source tree by following the same steps as in the similar bug I posted.
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2018-02-12 08:40:04 UTC 
Hi,

Can you generate a patch for the source tree?

I can test it.

--HPS
Comment 2 tom@tomdignan.com 2018-02-12 13:13:46 UTC 
Will do this afternoon
Comment 3 tom@tomdignan.com 2018-02-13 02:40:08 UTC 
Created attachment 190561 [details]
Corsair K70 RGB Keyboard Patch

This patch is against the current HEAD in svn.
Comment 4 tom@tomdignan.com 2018-02-13 02:41:16 UTC 
Created attachment 190562 [details]
Corsair K70 RGB Keyboard Patch(11.1-RELEASE)

This patch is against the source distributed with 11.1. It was created by initializing a git repo in /usr/src.
Comment 5 Hans Petter Selasky freebsd_committer freebsd_triage 2018-02-13 08:13:52 UTC 
Thank you for the patch. I'm thinking we should flag all Corsair keyboards instead of adding these patches.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-02-13 08:14:15 UTC 
A commit references this bug:

Author: hselasky
Date: Tue Feb 13 08:13:20 UTC 2018
New revision: 329195
URL: https://svnweb.freebsd.org/changeset/base/329195

Log:
  Add new USB quirk.

  PR:		225844
  MFC after:	1 week
  Sponsored by:	Mellanox Technologies

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-02-26 07:58:10 UTC 
A commit references this bug:

Author: hselasky
Date: Mon Feb 26 07:57:11 UTC 2018
New revision: 330013
URL: https://svnweb.freebsd.org/changeset/base/330013

Log:
  MFC r329195:
  Add new USB quirk.

  PR:		225844
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/11/
  stable/11/sys/dev/usb/quirk/usb_quirk.c
  stable/11/sys/dev/usb/usbdevs
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-02-26 07:58:13 UTC 
A commit references this bug:

Author: hselasky
Date: Mon Feb 26 07:57:56 UTC 2018
New revision: 330014
URL: https://svnweb.freebsd.org/changeset/base/330014

Log:
  MFC r329195:
  Add new USB quirk.

  PR:		225844
  Sponsored by:	Mellanox Technologies

Changes:
_U  stable/10/
  stable/10/sys/dev/usb/quirk/usb_quirk.c
  stable/10/sys/dev/usb/usbdevs