Bug 225855 - filename issues for Catalan timedef
Summary: filename issues for Catalan timedef
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: standards (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Pankov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-13 00:54 UTC by Robert Buj Gelonch
Modified: 2020-12-08 07:39 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Buj Gelonch 2018-02-13 00:54:33 UTC 
1st ISSUE:

Undo the modification of share/timedef/ca_IT.ISO8859-15.src in this commit https://github.com/freebsd/freebsd/commit/a93bef509a472e40f8b36b61c58ff0c227e83f6b

The file share/timedef/ca_IT.ISO8859-15.src it is not for Canada, it's Catalan in Italy. See http://www.unicode.org/cldr/charts/latest/summary/ca.html

-------

2nd ISSUE:

Rename the following files and update share/timedef/Makefile:

share/timedef/ca_IT.ISO8859-15.src -> share/timedef/ca.ISO8859-15.src
share/timedef/ca_IT.UTF-8.src -> share/timedef/ca.UTF-8.src

The root code for Catalan language, it's "ca", it is not ca_IT (Catalan in Italy). See http://www.unicode.org/cldr/charts/latest/summary/ca.html
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-10-17 16:39:39 UTC 
A commit references this bug:

Author: yuripv
Date: Wed Oct 17 16:38:45 UTC 2018
New revision: 339412
URL: https://svnweb.freebsd.org/changeset/base/339412

Log:
  Revert r315571 for share/timedef/ca_IT.ISO8859-15.src, ca_IT is Catalan
  in Italy, and is not related to Canada.

  While here, remove the header as we do NOT currently use CLDR data to
  generate timedef, and it's misleading.

  PR:		225855
  Reviewed by:	bapt
  Approved by:	re (gjb), kib (mentor)
  Differential Revision:	https://reviews.freebsd.org/D17551

Changes:
  head/share/timedef/ca_IT.ISO8859-15.src
Comment 2 Yuri Pankov freebsd_committer freebsd_triage 2018-10-17 16:47:15 UTC 
Robert, I have reverted the modification described in #1.

For #2, renaming the files doesn't serve any purpose as it would not have any effect on the resulting locale data, and is actually unhelpful if/when we change back to using CLDR data.