Bug 226012 - net/socat: [PATCH] Fix Makefile dependency so that parallel make is reliable
Summary: net/socat: [PATCH] Fix Makefile dependency so that parallel make is reliable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-02-18 21:29 UTC by Craig Leres
Modified: 2018-02-19 22:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
patch to fix Makefile dependancy needed for parallel make (1.24 KB, text/plain)
2018-02-18 21:29 UTC, Craig Leres
leres: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer 2018-02-18 21:29:51 UTC
Created attachment 190758 [details]
patch to fix Makefile dependancy needed for parallel make

net/socat occasionally fails to build on all three of my poudriere build servers. When I investigated I found that the Makefile was missing dependencies on two object files: vsnprintf_r.o snprinterr.o

Here's an example build failure:

    cc -O2 -pipe  -I/usr/local/include -Wno-unused-comparison -fstack-protector -fno-strict-aliasing -D_GNU_SOURCE -Wall -Wno-parentheses  -DHAVE_CONFIG_H -I. -Wl,-rpath,/usr/local/lib -L/usr/local/lib -fstack-protector -o filan filan_main.o filan.o fdname.o error.o sycls.o sysutils.o utils.o vsnprintf_r.o snprinterr.o -lwrap -lrt -lutil  -lssl -lcrypto
    cc: error: no such file or directory: 'vsnprintf_r.o'
    *** [filan] Error code 1

As expected it's one of the missing dependencies.

I submitted a patch upstream last September. The attached will solve this problem between now and (I assume) the next release of socat.

Assuming this looks ok, I'm happy to work this PR or if you want to take it that's good too.
Comment 1 Emanuel Haupt freebsd_committer 2018-02-19 20:19:49 UTC
Looks good to me. Please feel free to commit.
Comment 2 commit-hook freebsd_committer 2018-02-19 22:38:32 UTC
A commit references this bug:

Author: leres
Date: Mon Feb 19 22:38:05 UTC 2018
New revision: 462355
URL: https://svnweb.freebsd.org/changeset/ports/462355

Log:
  Patch socat/Makefile to reference all of dependencies when
  linking filan so that parallel make is reliable again.

  PR: 226012
  Reviewed by: ler (mentor)
  Approved by: ler (mentor)
  Differential Revision: https://reviews.freebsd.org/D14445

Changes:
  head/net/socat/files/patch-Makefile.in