Bug 226069 - net/librdkafka: USES=perl5 not required
Summary: net/librdkafka: USES=perl5 not required
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-20 17:21 UTC by Sergey Akhmatov
Modified: 2018-02-21 22:38 UTC (History)
1 user (show)

See Also:
pizzamig: maintainer-feedback+


Attachments
librdkafka.patch (661 bytes, patch)
2018-02-20 17:22 UTC, Sergey Akhmatov
sergey: maintainer-approval? (pizzamig)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Akhmatov 2018-02-20 17:21:11 UTC
- Can't find any reason for "USES=perl5". I think we should remove it.
- Python dependency is build-only: USES= python:build

While here:
- Move USES before USE to pet portlint

QA:
- poudriere testport OK
- portlint - minor warning
Comment 1 Sergey Akhmatov 2018-02-20 17:22:02 UTC
Created attachment 190831 [details]
librdkafka.patch
Comment 2 commit-hook freebsd_committer 2018-02-21 22:12:34 UTC
A commit references this bug:

Author: pizzamig
Date: Wed Feb 21 22:11:34 UTC 2018
New revision: 462547
URL: https://svnweb.freebsd.org/changeset/ports/462547

Log:
  net/librdkafka: Fix dependency

  As suggested, drop perl and demote python as build dependency

  PR:		226069
  Submitted by:	Sergey Akhmatov <sergey@akhmatov.ru>

Changes:
  head/net/librdkafka/Makefile
Comment 3 Luca Pizzamiglio freebsd_committer 2018-02-21 22:38:13 UTC
Thanks for reporting!