Bug 226151 - devel/devhelp: Disable -Werror (Fails to build due to warnings)
Summary: devel/devhelp: Disable -Werror (Fails to build due to warnings)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2018-02-24 02:03 UTC by Walter Schwarzenfeld
Modified: 2018-02-26 05:29 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback-


Attachments
svn-diff-devhelp-Werror (739 bytes, patch)
2018-02-24 05:11 UTC, Walter Schwarzenfeld
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2018-02-24 02:03:08 UTC
devhelp fails with:
mv -f .deps/libdevhelp_3_la-dh-enum-types.Tpo .deps/libdevhelp_3_la-dh-enum-types.Plo
dh-window.c:983:17: error: 'gtk_show_uri' is deprecated [-Werror,-Wdeprecated-declarations]
                gtk_show_uri (NULL, uri, GDK_CURRENT_TIME, NULL);
                ^
/usr/local/include/gtk-3.0/gtk/gtkshow.h:33:10: note: 'gtk_show_uri' declared here
gboolean gtk_show_uri  (GdkScreen   *screen,
         ^
1 error generated.
gmake[4]: *** [Makefile:842: libdevhelp_3_la-dh-window.lo] Error 1
dh-util.c:131:21: error: 'gdk_screen_get_width' is deprecated [-Werror,-Wdeprecated-declarations]
        dp = hypot (gdk_screen_get_width (screen), gdk_screen_get_height (screen));
                    ^
/usr/local/include/gtk-3.0/gdk/gdkscreen.h:58:14: note: 'gdk_screen_get_width' declared here
gint         gdk_screen_get_width             (GdkScreen   *screen);
             ^
dh-util.c:131:52: error: 'gdk_screen_get_height' is deprecated [-Werror,-Wdeprecated-declarations]
        dp = hypot (gdk_screen_get_width (screen), gdk_screen_get_height (screen));
                                                   ^
/usr/local/include/gtk-3.0/gdk/gdkscreen.h:60:14: note: 'gdk_screen_get_height' declared here
gint         gdk_screen_get_height            (GdkScreen   *screen);
             ^
dh-util.c:132:21: error: 'gdk_screen_get_width_mm' is deprecated [-Werror,-Wdeprecated-declarations]
        di = hypot (gdk_screen_get_width_mm (screen), gdk_screen_get_height_mm (screen)) / 25.4;
                    ^
/usr/local/include/gtk-3.0/gdk/gdkscreen.h:62:14: note: 'gdk_screen_get_width_mm' declared here
gint         gdk_screen_get_width_mm          (GdkScreen   *screen);
             ^
dh-util.c:132:55: error: 'gdk_screen_get_height_mm' is deprecated [-Werror,-Wdeprecated-declarations]
        di = hypot (gdk_screen_get_width_mm (screen), gdk_screen_get_height_mm (screen)) / 25.4;
                                                      ^
/usr/local/include/gtk-3.0/gdk/gdkscreen.h:64:14: note: 'gdk_screen_get_height_mm' declared here
gint         gdk_screen_get_height_mm         (GdkScreen   *screen);
             ^
dh-util.c:233:29: error: 'gdk_screen_get_width' is deprecated [-Werror,-Wdeprecated-declarations]
                max_width = gdk_screen_get_width (screen);
                            ^
/usr/local/include/gtk-3.0/gdk/gdkscreen.h:58:14: note: 'gdk_screen_get_width' declared here
gint         gdk_screen_get_width             (GdkScreen   *screen);
             ^
dh-util.c:234:30: error: 'gdk_screen_get_height' is deprecated [-Werror,-Wdeprecated-declarations]
                max_height = gdk_screen_get_height (screen);
                             ^
/usr/local/include/gtk-3.0/gdk/gdkscreen.h:60:14: note: 'gdk_screen_get_height' declared here
gint         gdk_screen_get_height            (GdkScreen   *screen);
             ^
6 errors generated.



with CFLAGS+=-Wno-deprecated-declarations

<unknown>:: Warning: Devhelp: (Signal)open-link: argument flags: Unresolved type: 'DhOpenLinkFlags'
<unknown>:: Fatal: Devhelp: warnings configured as fatal
<unknown>:: Fatal: Devhelp: warnings configured as fatal


Compiles fine with 
CONFIGURE_ARGS+=        --disable-Werror

configure --help:
--disable-Werror        Unconditionally make all compiler warnings non-fatal
                                                          ^^^^^^^^^^^^^^^^^^
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-02-24 04:21:08 UTC
Thank you for the report Walter. Could you please attach a patch so that it can be approved (with a flag)
Comment 2 Walter Schwarzenfeld freebsd_triage 2018-02-24 05:11:38 UTC
Created attachment 190931 [details]
svn-diff-devhelp-Werror
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-02-24 07:59:37 UTC
Comment on attachment 190931 [details]
svn-diff-devhelp-Werror

Approved by: portmgr (port compliance, infrastructure)
Comment 4 Kurt Jaeger freebsd_committer 2018-02-26 05:28:56 UTC
committed, thanks.
Comment 5 commit-hook freebsd_committer 2018-02-26 05:29:14 UTC
A commit references this bug:

Author: pi
Date: Mon Feb 26 05:28:43 UTC 2018
New revision: 462991
URL: https://svnweb.freebsd.org/changeset/ports/462991

Log:
  devel/devhelp: Disable -Werror (Fails to build due to warnings)

  PR:		226151
  Submitted by:	Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
  Approved by:	portmgr (port compliance, infrastructure)

Changes:
  head/devel/devhelp/Makefile