Bug 226172 - [asmc] [patch] Add Support for MacBookAir 7,1 and 7,2
Summary: [asmc] [patch] Add Support for MacBookAir 7,1 and 7,2
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Some People
Assignee: David Bright
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-02-24 15:27 UTC by James Wright
Modified: 2018-12-20 01:08 UTC (History)
2 users (show)

See Also:
dab: mfc-stable12+
dab: mfc-stable11+
dab: mfc-stable10-

Attachments
asmc module patch (2.58 KB, patch)
2018-02-24 15:27 UTC, James Wright 		no flags Details | Diff
Patch to add MacBookAir 7,1 and 7,2 to asmc (2.53 KB, patch)
2018-10-27 23:36 UTC, James Wright 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Wright 2018-02-24 15:27:51 UTC 
Created attachment 190959 [details]
asmc module patch

Patch to add support to asmc module for MacBookAir 2015 models.

Please could someone review and commit?

Result of patch running on a MacBookAir 2015 13" model;

# kldload asmc
# sysctl -a | grep asmc

dev.asmc.0.light.control: 0
dev.asmc.0.light.right: 0
dev.asmc.0.light.left: 0
dev.asmc.0.temp.palmrest: 23
dev.asmc.0.temp.mainboardproximity: 22
dev.asmc.0.temp.heatpipe: 25
dev.asmc.0.temp.airflowproximity: 24
dev.asmc.0.temp.wirelessproximity: 26
dev.asmc.0.temp.pchdie: 34
dev.asmc.0.temp.memorybank: 29
dev.asmc.0.temp.thunderboltproximity: 24
dev.asmc.0.temp.pecicpu: 37
dev.asmc.0.temp.pecisa: 0
dev.asmc.0.temp.pecigpu: 38
dev.asmc.0.temp.cpucore2: 38
dev.asmc.0.temp.cpucore1: 37
dev.asmc.0.temp.cpuproximity: 31
dev.asmc.0.temp.cputemp2: 39
dev.asmc.0.temp.cputemp1: 38
dev.asmc.0.temp.enclosure3: 22
dev.asmc.0.temp.enclosure2: 22
dev.asmc.0.temp.enclosure1: 22
dev.asmc.0.fan.0.targetspeed: 1200
dev.asmc.0.fan.0.maxspeed: 6500
dev.asmc.0.fan.0.minspeed: 1200
dev.asmc.0.fan.0.speed: 1200
dev.asmc.0.fan.0.id: Exhaust  
dev.asmc.0.%parent: acpi0
dev.asmc.0.%pnpinfo: _HID=APP0001 _UID=0
dev.asmc.0.%location: handle=\_SB_.PCI0.LPCB.SMC_
dev.asmc.0.%driver: asmc
dev.asmc.0.%desc: Apple SMC MacBook Air 13-inch (Early 2015)
dev.asmc.%parent:
Comment 1 James Wright 2018-10-27 23:36:27 UTC 
Created attachment 198702 [details]
Patch to add MacBookAir 7,1 and 7,2 to asmc

Updated diff against CURRENT
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-12-11 16:36:59 UTC 
A commit references this bug:

Author: dab
Date: Tue Dec 11 16:35:59 UTC 2018
New revision: 341820
URL: https://svnweb.freebsd.org/changeset/base/341820

Log:
  asmc: Add Support for MacBookAir 7,1 and 7,2

  PR:		226172
  Submitted by:	James Wright <james.wright@jigsawdezign.com>
  Reported by:	James Wright <james.wright@jigsawdezign.com>
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D18396

Changes:
  head/sys/dev/asmc/asmc.c
  head/sys/dev/asmc/asmcvar.h
Comment 3 David Bright freebsd_committer freebsd_triage 2018-12-11 16:38:47 UTC 
Will MFC to stable12 & stable11; no intention to MFC to stable10.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-12-19 21:29:07 UTC 
A commit references this bug:

Author: dab
Date: Wed Dec 19 21:28:12 UTC 2018
New revision: 342241
URL: https://svnweb.freebsd.org/changeset/base/342241

Log:
  MFC r341820:

  asmc: Add Support for MacBookAir 7,1 and 7,2

  PR:		226172
  Submitted by:	James Wright <james.wright@jigsawdezign.com>
  Reported by:	James Wright <james.wright@jigsawdezign.com>

Changes:
_U  stable/12/
  stable/12/sys/dev/asmc/asmc.c
  stable/12/sys/dev/asmc/asmcvar.h
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-19 22:17:46 UTC 
A commit references this bug:

Author: dab
Date: Wed Dec 19 22:17:25 UTC 2018
New revision: 342246
URL: https://svnweb.freebsd.org/changeset/base/342246

Log:
  MFC r341820:

  asmc: Add Support for MacBookAir 7,1 and 7,2

  PR:		226172
  Submitted by:	James Wright <james.wright@jigsawdezign.com>
  Reported by:	James Wright <james.wright@jigsawdezign.com>

Changes:
_U  stable/11/
  stable/11/sys/dev/asmc/asmc.c
  stable/11/sys/dev/asmc/asmcvar.h
Comment 6 David Bright freebsd_committer freebsd_triage 2018-12-20 01:08:26 UTC 
MFC complete; closing.