Bug 226204 - [patch] emulators/open-vm-tools use kldstat -qn, sort pkg-plist amd make fuse optional
Summary: [patch] emulators/open-vm-tools use kldstat -qn, sort pkg-plist amd make fuse...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-02-25 18:39 UTC by Olli Hauer
Modified: 2021-03-25 12:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jpaetzel)

Attachments
patch-open-vm-tools (5.85 KB, patch)
2018-02-25 18:39 UTC, Olli Hauer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2018-02-25 18:39:26 UTC 
Created attachment 190998 [details]
patch-open-vm-tools

A small improvement for the rc script:
 - use "kldstat -qn" instead "kldstat -n >/dev/null 2>&1" this is available on all supported FreeBSD releases.

- make fuse optional, it is an addon that is useless on vSphere servers, indeed if you install tools on Linux with the vmware install script there is the ability to not install fuse or hgfs at all per default on vSphere.

- disable grabbitmqproxy, procps and deploypkg which are not supported on FreeBSD

- install a sample tools.conf and set [logging]vmsvc.level=error
 ( I haven't tested with the UFS patch from latest commit, but without that line I had every 5 sec. an entry in log/messsages)

- cleanup Makefile, some directories are created by default and the lines are no longer required with pkgng.

- sort and cleanup pkg-plist, so it is easier to apply local patches (e.g. remove fuse plus libhg parts so they are not installed at all)
Comment 1 Josh Paetzel freebsd_committer freebsd_triage 2018-10-25 15:49:13 UTC 
I don't know how this bug slipped through the cracks but I'll work on it soon.
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2021-03-25 12:13:22 UTC 
A commit references this bug:

Author: garga
Date: Thu Mar 25 12:10:02 UTC 2021
New revision: 569197
URL: https://svnweb.freebsd.org/changeset/ports/569197

Log:
  emulators/open-vm-tools: Update to 11.2.5 and other changes

  - Update to 11.2.5 [1]
  - Make fuse dependency optional adding new FUSE option, enabled by default [2]
  - Remove CONFLICTS with packages that were removed years ago
  - Remove DOCS items from pkg-plist and use PORTDOCS instead
  - Install default tools.conf [1]
  - Do not mkdir directories not covered by pkg-plist
  - Rework patch-lib_guestApp_guestApp.c to respect ${PREFIX}
  - vmware-kmod.in:
  	- Simplify logic
  	- Use kldstat -q instead of redirect stdout/stderr [2]
  - Partially restore @preunexec removed in r473438.  Set tools.set.version as 0
    is important to let hypervisor to be notified package is removed.  Otherwise
    vCenter console shows tools status as "installed" but "not-running". [3]

  PR:		252699 [1]
  		226204 [2]
  		246440 [3]
  Submitted by:	John Wolfe <jwolfe@vmware.com> [1] [3]
  		ohauer [2]
  Sponsored by:	Rubicon Communications, LLC ("Netgate")

Changes:
  head/emulators/open-vm-tools/Makefile
  head/emulators/open-vm-tools/distinfo
  head/emulators/open-vm-tools/files/patch-lib_guestApp_guestApp.c
  head/emulators/open-vm-tools/files/vmware-kmod.in
  head/emulators/open-vm-tools/pkg-plist