Bug 226297 - accessibility/sct: Update to 0.2.1
Summary: accessibility/sct: Update to 0.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-02 13:42 UTC by Mateusz Piotrowski
Modified: 2018-03-03 15:22 UTC (History)
1 user (show)

See Also:
0mp: maintainer-feedback+

Attachments
Update to 0.2.1 for sct (svn diff) (1.24 KB, patch)
2018-03-02 13:42 UTC, Mateusz Piotrowski 		0mp: maintainer-approval+
Details | Diff
Update to 0.2.1 for sct (svn diff) (revision 1) (1.90 KB, patch)
2018-03-02 15:03 UTC, Mateusz Piotrowski 		0mp: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-03-02 13:42:41 UTC 
Created attachment 191135 [details]
Update to 0.2.1 for sct (svn diff)

Changes:
 * Add a manual page.
 * The post-installation stripping has been moved to upstream.
 * Set LICENSE_FILE.

QA:
 * Poudriere: 11.1-RELEASE amd64
 * My machine: FreeBSD 12.0-CURRENT amd64 (r329183)

BTW, I am the maintainer of this port.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2018-03-02 13:42:41 UTC 
Maintainer informed via mail
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-02 13:57:23 UTC 
Thank you Mateusz.

Could you please update your Bugzilla email address to match your port MAINTAINER lines (or vice versa) This is so that we can set maintainer-feedback/approval requests appropriately (an account in the system with the maintainers email address is necessary), and to avoid ambiguity/incorrect approvals

Please also set maintainer-approval to + (on attachments)  for patches of ports you maintain. Attachment -> Details -> maintainer-approval [+].
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-03-02 14:59:53 UTC 
(In reply to Kubilay Kocak from comment #2)

Done. I've successfully switch to my @FreeBSD.org account. :)

Also, I'll send an updated patch in a minute. I forgot to update pkg-descr (parts of it have been moved to a manual).
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-03-02 15:03:54 UTC 
Created attachment 191137 [details]
Update to 0.2.1 for sct (svn diff) (revision 1)

Remove parts of pkg-descr, which have been moved to a manual page upstream.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-03-03 09:00:29 UTC 
A commit references this bug:

Author: yuri
Date: Sat Mar  3 08:59:34 UTC 2018
New revision: 463470
URL: https://svnweb.freebsd.org/changeset/ports/463470

Log:
  accessibility/sct: Update to 0.2.1

  Port changes:
  * Changed to DISTVERSION
  * Added LICENSE_FILE
  * Added manpage
  * Removed stripping - now done upstream

  PR:		226297
  Submitted by:	Mateusz Piotrowski <0mp@FreeBSD.org> (maintainer)
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/accessibility/sct/Makefile
  head/accessibility/sct/distinfo
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-03 09:01:04 UTC 
Committed with small changes.
Thank you for the update!

You didn't include pkg-descr deletion in "Changes", so I assumed it is accidental.

Thank you for maintaining ports!
Yuri
Comment 7 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-03-03 14:24:43 UTC 
(In reply to Yuri Victorovich from comment #6)

Thank you for committing those changes!

Actually, I wanted to remove some parts of pkg-descr. This is why I updated the patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=191137&action=edit
The somewhat updated change set was mentioned here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226297#c4

It is not a big problem, however. I may resubmit those changes next time. :)
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-03 15:22:30 UTC 
(In reply to Mateusz Piotrowski from comment #7)

You're welcome!

You can delete descr next time then. :)

Yuri