Bug 226337 - Some elements are disappeared from new bug report submitting form
Summary: Some elements are disappeared from new bug report submitting form
Status: In Progress
Alias: None
Product: Services
Classification: Unclassified
Component: Bug Tracker (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Many People
Assignee: Oleksandr Tymoshenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-04 05:26 UTC by Yasuhiro KIMURA
Modified: 2018-03-06 04:03 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro KIMURA 2018-03-04 05:26:41 UTC
Today I tried to submit new bug report of "Ports & Packages" and found some elements are disappeared from submitting form. That is,

* I can't set flags such as maintainer-feedback, exp-run and 	
merge-quarterly.
* I can't set content type of attachment.

Are these changes intended ones?
Comment 1 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2018-03-04 05:54:16 UTC
These elements should be available to any user. I think they're hidden by defaults. On bug report form there should  "Show Advanced Fields" link. when clicked it should reveal flags, "Add attachment" button, etc... the same link should be present on attachment form.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-04 08:01:16 UTC
@Oleksandr I noticed a similar change in default preferences recently (month or so), though I had show advanced fields enabled in my user prefs, they defaulted to hidden. I'm not sure what configuration changed or when.

Unless this change can be reverted (to previous settings/default), Advanced should be the default, until/pending using a template that only includes (all) the fields we want to show up by default, which includes flags
Comment 3 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2018-03-04 08:36:02 UTC
(In reply to Kubilay Kocak from comment #2)

Hmm. I don't remember changing anything in Preferences page or touching this functionality in code. Current configuration is set to "Remember state". I'll look into possible causes in next few days.
Comment 4 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2018-03-04 08:40:23 UTC
(In reply to Kubilay Kocak from comment #2)

Should the default be switched to On ASAP?
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-04 08:47:56 UTC
(In reply to Oleksandr Tymoshenko from comment #4)

No rush, certainly not until we can determine what if anything has changed, and it gives us time to consider what a better target state might look like and why. Has there been any version update in the past month or three?

@Yasuhiro, in the meantime, you should always see 'Advanced Fields' after enabling it. If not let us know. 

Also check the "Initially hide the advanced fields in bug editor" preference in: https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=settings
Comment 6 Yasuhiro KIMURA 2018-03-04 11:06:48 UTC
(In reply to Kubilay Kocak from comment #5)

I didn't know there is such setting in preference. Thank you for letting me know. But I think advanced fields themselves should be displayed by default as before. Especially content type setting of attachment is necessary to submit patch properly.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-04 11:31:34 UTC
(In reply to Yasuhiro KIMURA from comment #6)

Ideally this shouldn't be necessary, and shouldn't be anymore (see See Also bugs)

If there's still an issue please let us know.
Comment 8 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2018-03-05 22:15:47 UTC
(In reply to Kubilay Kocak from comment #5)


On Dec 31 two extensions were installed (I believe by eadler@), one of them, BugViewPlus, modifies default bug view behavior and provides option for configuring state of "Advanced fields"
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-06 04:00:06 UTC
I noticed them in the administration settings, but didn't make the connection.

@Eitan Is there background/information for what these were installed to improve/solve? That would have been handy at the time and would be good to document now.

My guess is "bvp_simple_fields_selector" and/or "bvp_inline_editor" as they have been enabled
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-06 04:03:09 UTC
I think the inline editor is what has added the [+]'s in bug (list) results, though I'm sure not whether (and to what extent) it takes permissions/groups/etc into account