Bug 226338 - devel/git-lfs: Update to 2.4.0
Summary: devel/git-lfs: Update to 2.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-04 05:51 UTC by Kenji Rikitake
Modified: 2018-03-04 08:59 UTC (History)
1 user (show)

See Also:
kenji: maintainer-feedback+


Attachments
Patch of devel/git-lfs diff from 2.3.4 to 2.4.0 (1.40 KB, patch)
2018-03-04 05:51 UTC, Kenji Rikitake
kenji: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenji Rikitake 2018-03-04 05:51:45 UTC
Created attachment 191191 [details]
Patch of devel/git-lfs diff from 2.3.4 to 2.4.0

Port devel/git-lfs diff from 2.3.4 to 2.4.0

Changes:
    https://github.com/git-lfs/git-lfs/releases/tag/v2.4.0

QA: poudriere testport passed for 10.4-RELEASE-p5 and 11.1-RELEASE-p6
    both on i386 and amd64 architectures

Fixes:

* Set GOCACHE=off so that root/.cache is not created
  (Without this the poudriere build tests did not pass)
  See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226320
  for the related discussions

* Modify Makefile do-build label to respect the default env settings in Mk/Uses/go.mk
Comment 1 Yuri Victorovich freebsd_committer 2018-03-04 06:06:30 UTC
A lot of go ports fail with /root/.cache. portmgr should probably decide what should be generally done about this. Shouldn't just set GO_ENV+=	GOCACHE=off everywhere.
Comment 2 Kenji Rikitake 2018-03-04 06:11:12 UTC
(In reply to Yuri Victorovich from comment #1)

Yes, I agree with you that the general /root/.cache should be handled by the portmgr.

OTOH, this update also has a patch for the upstream update other than the GO_ENV stuff, so I'll keep it here anyway.
Comment 3 Yuri Victorovich freebsd_committer 2018-03-04 06:14:34 UTC
(In reply to Kenji Rikitake from comment #2)

Yes, thanks. Need to wait until the general resolution.
Comment 4 Antoine Brodin freebsd_committer 2018-03-04 06:22:08 UTC
(In reply to Yuri Victorovich from comment #3)
This doesn't need to wait,  why doesn't this port respect MAKE_ENV ?
Comment 5 Yuri Victorovich freebsd_committer 2018-03-04 06:26:54 UTC
(In reply to Antoine Brodin from comment #4)

But does MAKE_ENV now solve this problem?
Comment 6 Yuri Victorovich freebsd_committer 2018-03-04 06:27:58 UTC
For some weird reason, I never saw this problem myself.
Comment 7 Kenji Rikitake 2018-03-04 06:31:25 UTC
(In reply to Antoine Brodin from comment #4)
I've fixed this port to respect MAKE_ENV and GO_ENV. See Makefile do-build label in the patch. Quote:

-- quote from patch --
do-build:
-	cd ${WRKSRC} && ${MKDIR} ${WRKSRC}/.tmp && TMPDIR=${WRKSRC}/.tmp script/bootstrap
+	cd ${WRKSRC} && ${MKDIR} ${WRKSRC}/.tmp && ${SETENV} ${MAKE_ENV} ${GO_ENV} TMPDIR=${WRKSRC}/.tmp script/bootstrap
-- quote ends here --
Comment 8 Yuri Victorovich freebsd_committer 2018-03-04 06:37:01 UTC
Kenji,

Why does this port need RUN_DEPENDS bash?
Comment 9 Kenji Rikitake 2018-03-04 06:45:32 UTC
(In reply to Yuri Victorovich from comment #8)
It's been a while so I really don't remember about the reason why I added bash dependency, but I remember I did it when I rescued the port from the broken state.

See:

https://svnweb.freebsd.org/ports/head/devel/git-lfs/Makefile?r1=423051&r2=425729
https://svnweb.freebsd.org/ports?view=revision&revision=425729

Also, the script/bootstrap file has a bash dependency. See:

https://github.com/git-lfs/git-lfs/blob/master/script/bootstrap
Comment 10 Yuri Victorovich freebsd_committer 2018-03-04 06:48:04 UTC
BUILD_DEPENDS isn't needed, it works with Bourn shell.
I suspect it doesn't need run-time bash either, because it is just one binary executable.
Comment 11 Yuri Victorovich freebsd_committer 2018-03-04 07:04:43 UTC
Committed.
Thank you for the update!

(I am pretty sure that bash isn't needed during the runtime.)
Comment 12 commit-hook freebsd_committer 2018-03-04 07:04:56 UTC
A commit references this bug:

Author: yuri
Date: Sun Mar  4 07:04:37 UTC 2018
New revision: 463553
URL: https://svnweb.freebsd.org/changeset/ports/463553

Log:
  devel/git-lfs: Update to 2.4.0

  Port changes:
  * Removed RUN_DEPENDS=bash (doesn't seem to be needed)
  * Silenced the do-build command
  * Renamed pre-install -> do-install
  * Use ${MAKE_ENV} and ${GO_ENV}

  PR:		226338
  Submitted by:	Kenji Rikitake <kenji@k2r.org> (maintainer)
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/devel/git-lfs/Makefile
  head/devel/git-lfs/distinfo
Comment 13 Kenji Rikitake 2018-03-04 08:52:59 UTC
(In reply to Yuri Victorovich from comment #10)
Yes, I think you don't need bash to *run* this software. I agree with you.
BTW thanks for the prompt update!
Comment 14 Yuri Victorovich freebsd_committer 2018-03-04 08:59:51 UTC
(In reply to Kenji Rikitake from comment #13)

You're welcome!