Bug 226360 - devel/p5-Any-Daemon: update to 0.95
Summary: devel/p5-Any-Daemon: update to 0.95
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2018-03-05 10:15 UTC by Martin Waschbüsch
Modified: 2018-03-05 17:16 UTC (History)
0 users

See Also:


Attachments
update p5-Any-Daemon to 0.95 (918 bytes, patch)
2018-03-05 10:15 UTC, Martin Waschbüsch
martin: maintainer-approval+
Details | Diff
poudriere buildlog (19.36 KB, text/plain)
2018-03-05 10:17 UTC, Martin Waschbüsch
martin: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Waschbüsch 2018-03-05 10:15:57 UTC
Created attachment 191216 [details]
update p5-Any-Daemon to 0.95
Comment 1 Martin Waschbüsch 2018-03-05 10:17:37 UTC
Created attachment 191217 [details]
poudriere buildlog

Output of
poudriere testport -j test-11-1 devel/p5-Any-Daemon

test-11-1 being a 11.1-RELEASE amd64 jail.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-03-05 12:56:15 UTC
Thank you Martin,

Attaching logs is not necessary, just confirm that QA has passed, eg:

- portlint: OK (looks fine.)
- testport: OK (poudriere: <versions>, <archs>, <options> tested)
- maketest: OK (if available)

Don't forget to set maintainer-approval to + on attachments for ports you are maintainer of. Attachment -> Details -> maintainer-approval [+]
Comment 3 Martin Waschbüsch 2018-03-05 15:09:14 UTC
(In reply to Kubilay Kocak from comment #2)

I will try to remember these. Thank you very much!

Aside: Is there a writeup somewhere of dos and don'ts concerning PRs? I do not maintain a lot of ports, so there is little routine in it and I would like to avoid making the same mistakes over and over again.
Comment 4 Martin Waschbüsch 2018-03-05 15:22:48 UTC
QA:

- testport: OK (poudriere: 11.1-RELEASE, amd64, default options tested, see attachment)
Comment 5 Sunpoet Po-Chuan Hsieh freebsd_committer 2018-03-05 15:54:01 UTC
Hi,

Besides the version upgrade, I'll fix 2 things:
- LICENSE: this port uses the same license as Perl. it's ART10 and GPLv1+.
- The dependency:
  - p5-File-Spec-Native is not used in current version so I removed it.
  - Update version requirement of p5-Log-Report-Optional
  - Add BUILD_DEPENDS

Index: Makefile
===================================================================
--- Makefile    (revision 463649)
+++ Makefile    (working copy)
@@ -12,10 +12,11 @@
 MAINTAINER=    martin@waschbuesch.de
 COMMENT=       Provides basic needs for a daemon

-LICENSE=       ART10
+LICENSE=       ART10 GPLv1+
+LICENSE_COMB=  dual

-RUN_DEPENDS:=  p5-Log-Report-Optional>=0:devel/p5-Log-Report-Optional \
-               p5-File-Spec-Native>=0:devel/p5-File-Spec-Native
+BUILD_DEPENDS= p5-Log-Report-Optional>=1.06:devel/p5-Log-Report-Optional
+RUN_DEPENDS:=  ${BUILD_DEPENDS}

 USES=          perl5
 USE_PERL5=     configure
Comment 6 Sunpoet Po-Chuan Hsieh freebsd_committer 2018-03-05 17:16:01 UTC
Committed. Thanks!
Comment 7 commit-hook freebsd_committer 2018-03-05 17:16:43 UTC
A commit references this bug:

Author: sunpoet
Date: Mon Mar  5 17:15:32 UTC 2018
New revision: 463666
URL: https://svnweb.freebsd.org/changeset/ports/463666

Log:
  Update to 0.95

  - While I'm here:
    - Fix LICENSE
    - Add BUILD_DEPENDS
    - Fix *_DEPENDS: File::Spec::Native is not required
    - Fix version requirement of *_DEPENDS

  Changes:	http://search.cpan.org/dist/Any-Daemon/ChangeLog
  PR:		226360
  Submitted by:	Martin Waschbusch <martin@waschbuesch.de> (maintainer)

Changes:
  head/devel/p5-Any-Daemon/Makefile
  head/devel/p5-Any-Daemon/distinfo