Bug 226460 - devel/libical: segmentation fault with evolution-calendar-factory
Summary: devel/libical: segmentation fault with evolution-calendar-factory
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Don Lewis
URL: https://github.com/libical/libical/co...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-08 19:48 UTC by Carlos J. Puga Medina
Modified: 2018-03-20 02:59 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
patch-libical.diff (28.57 KB, patch)
2018-03-09 23:11 UTC, Carlos J. Puga Medina
no flags Details | Diff
patch-libical.diff (28.63 KB, patch)
2018-03-10 11:49 UTC, Carlos J. Puga Medina
cpm: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer 2018-03-08 19:48:30 UTC
It seems that evolution-calendar-factory crashes at startup.

dmesg output shows these lines:

pid 1315 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 1321 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 1336 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 1340 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 1342 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 1346 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 1348 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 1351 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)
pid 3474 (evolution-calendar-), uid 1001: exited on signal 11 (core dumped)

Here is the backtrace:

[New LWP 100636]
[New LWP 100491]
Core was generated by `evolution-calendar-'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000000080307b4ff in icaltzutil_fetch_timezone ()
   from /usr/local/lib/libical.so.2
[Current thread is 1 (LWP 100636)]

As a workaround, I run manually evolution-calendar-factory using the -w option to wait running until at least one client is connected.

% /usr/local/libexec/evolution-calendar-factory -w &
Comment 1 Carlos J. Puga Medina freebsd_committer 2018-03-09 23:11:45 UTC
Created attachment 191359 [details]
patch-libical.diff

- Add missing USE_GNOME=introspection:build
- Fix segmentation fault with evolution-calendar-factory
Comment 2 Carlos J. Puga Medina freebsd_committer 2018-03-09 23:19:06 UTC
All ports that depend on devel/libical require PORTREVISION bump.
Comment 3 Carlos J. Puga Medina freebsd_committer 2018-03-10 11:49:05 UTC
Created attachment 191370 [details]
patch-libical.diff

- Pet portlint, USE_* comes before USES.
Comment 4 Don Lewis freebsd_committer 2018-03-15 23:59:27 UTC
(In reply to Carlos J. Puga Medina from comment #2)

Why do the dependent ports need a revision bump?  It doesn't
look like there is an ABI change, and the dependent ports
all look like they are doing dynamic linking.
Comment 5 Carlos J. Puga Medina freebsd_committer 2018-03-16 00:34:38 UTC
(In reply to Don Lewis from comment #4)

Because the obsolete code was removed upstream

https://github.com/libical/libical/commit/77f82ba88abbb633dc52335fcc050bec3b41c269#diff-501f2f5b99a715d762d3ceee6a1169a9
Comment 6 Carlos J. Puga Medina freebsd_committer 2018-03-16 00:48:02 UTC
(In reply to Carlos J. Puga Medina from comment #5)

This code has been replaced and the old functions defined in the libical.so.2 library will not be loaded.
Comment 7 commit-hook freebsd_committer 2018-03-20 02:52:50 UTC
A commit references this bug:

Author: truckman
Date: Tue Mar 20 02:52:28 UTC 2018
New revision: 465060
URL: https://svnweb.freebsd.org/changeset/ports/465060

Log:
  Import upstream patch:
  https://github.com/libical/libical/commit/77f82ba88abbb633dc52335fcc050bec3b41c2
  69

    icaltzutil_fetch_timezone now creates VTIMEZONE components using
    RRULEs rather than expanding out every year (if
    USE_INTEROPERATIVE_VTIMEZONES was off) or using a single time zone
    back to 1970 (if it was one).

    This creates more accurate time zones that are compatible with dates
    whose time zones have since transitioned to a different offset (such
    as a date in America/New_York in 1980).  Removed
    icaltzutil_set_exact_vtimezones_support and
    icaltzutil_get_exact_vtimezones_support.  Removed
    USE_INTEROPERABLE_VTIMEZONES.

  Add missing USE_GNOME=introspection:build

  Fix segmentation fault with evolution-calendar-factory

  Pet portlint, USE_* comes before USES

  PR:		226460
  Submitted by:	cpm
  Obtained from:	github libical/libical (partially)

Changes:
  head/devel/libical/Makefile
  head/devel/libical/files/
  head/devel/libical/files/patch-src_libical_icaltz-util.c
  head/devel/libical/files/patch-src_libical_icaltz-util.h
  head/devel/libical/files/patch-src_test_timezones.c
Comment 8 commit-hook freebsd_committer 2018-03-20 02:54:54 UTC
A commit references this bug:

Author: truckman
Date: Tue Mar 20 02:54:25 UTC 2018
New revision: 465061
URL: https://svnweb.freebsd.org/changeset/ports/465061

Log:
  Bump PORTREVISION on ports depending on devel/libical.

  PR:		226460

Changes:
  head/comms/gnokii/Makefile
  head/converters/ical2html/Makefile
  head/databases/evolution-data-server/Makefile
  head/deskutils/cairo-dock-plugins/Makefile
  head/deskutils/gnome-calendar/Makefile
  head/deskutils/kdepimlibs-kde4/Makefile
  head/deskutils/orage/Makefile
  head/deskutils/osmo/Makefile
  head/deskutils/simpleagenda/Makefile
  head/finance/kmymoney-kde4/Makefile
  head/games/goldencheetah/Makefile
  head/mail/claws-mail-vcalendar/Makefile
  head/mail/cyrus-imapd25/Makefile
  head/mail/cyrus-imapd30/Makefile
  head/mail/evolution/Makefile
  head/mail/evolution-ews/Makefile
  head/misc/wmcalendar/Makefile
  head/x11/gnome-shell/Makefile