Bug 226511 - [patch] japanese/font-ayu18 japanese/font-ayu20 japanese/font-elisa10 japanese/font-shinonome: Cannot use the font files with the latest x11-fonts/libXfont
Summary: [patch] japanese/font-ayu18 japanese/font-ayu20 japanese/font-elisa10 japanes...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: MANTANI Nobutaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-11 09:22 UTC by WATANABE Kazuhiro
Modified: 2018-04-15 13:55 UTC (History)
3 users (show)

See Also:
nobutaka: maintainer-feedback-


Attachments
A patch for japanese/font-ayu18. (3.10 KB, patch)
2018-03-11 09:25 UTC, WATANABE Kazuhiro
no flags Details | Diff
A patch for japanese/font-ayu20 (4.31 KB, patch)
2018-03-11 09:26 UTC, WATANABE Kazuhiro
no flags Details | Diff
A patch for japanese/font-elisa10. (4.22 KB, patch)
2018-03-11 09:28 UTC, WATANABE Kazuhiro
no flags Details | Diff
A patch for japanese/font-shinonome. (5.88 KB, patch)
2018-03-11 09:29 UTC, WATANABE Kazuhiro
no flags Details | Diff
poudriere testport log with the patch (japanese/font-ayu18) (18.57 KB, text/plain)
2018-03-11 09:32 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log with the patch (japanese/font-ayu20) (17.78 KB, text/plain)
2018-03-11 09:34 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log with the patch (japanese/font-elisa10) (16.79 KB, text/plain)
2018-03-11 09:35 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log with the patch (japanese/font-shinonome) (18.43 KB, text/plain)
2018-03-11 09:37 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2018-03-11 09:22:25 UTC
As described in bug #225125, japanese/font-ayu18, japanese/font-ayu20,
japanese/font-elisa10 and japanese/font-shinonome has not been usable
since the latest update of x11-fonts/libXfont (CVE-2017-16611).

Because these ports installs font files as symbolic links, and the latest
x11-fonts/libXfont does not handle other than regular font files.

* How to repeat
** Without the patch
*** japanese/font-ayu18

 $ pkg info --show-name-only libXfont
 libXfont-1.5.4,2                       # > 1.5.2,2
 $ pkg install ja-font-ayu18
 $ xset fp rehash
 $ xlsfonts -fn -ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0
 -ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0
 $ xlsfonts -ll -fn -ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0
 xlsfonts:  unable to get info about font "-ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0"
 $ 

*** japanese/font-ayu20

 $ pkg install ja-font-ayu20
 $ xset fp rehash
 $ xlsfonts -fn k20gm
 k20gm
 $ xlsfonts -ll -fn k20gm
 xlsfonts:  unable to get info about font "k20gm"
 $ 

*** japanese/font-elisa10

 $ pkg install ja-font-elisa10
 $ xset fp rehash
 $ xlsfonts -fn elisa
 elisa
 $ xlsfonts -ll -fn elisa
 xlsfonts:  unable to get info about font "elisa"
 $ 

*** japanese/font-shinonome

 $ pkg install ja-font-shinonome
 $ xset fp rehash
 $ xlsfonts -fn k12min
 k12min
 $ xlsfonts -ll -fn k12min
 xlsfonts:  unable to get info about font "k12min"
 $ 

** With the patch
*** japanese/font-ayu18

 $ xset fp+ /usr/local/share/fonts/ayu18
 $ xlsfonts -fn -ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0
 -ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0
 $ xlsfonts -ll -fn -ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0
 name:  -ayu-mincho-medium-i-normal--0-0-75-75-c-0-jisx0208.1990-0
   direction:            left to right
   indexing:             matrix
   rows:                 0x21 thru 0x74 (33 thru 116)
   columns:              0x21 thru 0x7e (33 thru 126)
   all chars exist:      no
   default char:         0x2121 (8481)
   ascent:               10
   descent:              2
   font type:            Character Cell
   bounds:               width left  right  asc  desc   attr   keysym
         min               13    -2    15    11     3  0x03fb
         max               13    -2    15    11     3  0x03fb
   properties:           25
       FOUNDRY               ayu
       FAMILY_NAME           mincho
       WEIGHT_NAME           medium
       SLANT                 i
       SETWIDTH_NAME         normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            12
       POINT_SIZE            120
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               c
       AVERAGE_WIDTH         130
       CHARSET_REGISTRY      jisx0208.1990
       CHARSET_ENCODING      0
       FONT                  -ayu-mincho-medium-i-normal--12-120-75-75-c-130-jisx0208.1990-0
       RAW_ASCENT            849
       RAW_DESCENT           169
       RAW_PIXEL_SIZE        1000
       RAW_POINT_SIZE        964
       RAW_AVERAGE_WIDTH     10190
       WEIGHT                10
       X_HEIGHT              -1
       RAW_X_HEIGHT          -113
       QUAD_WIDTH            13
       RAW_QUAD_WIDTH        1019
 
 $ 

*** japanese/font-ayu20

 $ xset fp+ /usr/local/share/fonts/ayu20
 $ xlsfonts -fn k20gm
 k20gm
 $ xlsfonts -ll -fn k20gm
 name:  k20gm
(snip)
   properties:           21
       COPYRIGHT             public domain
       FONTNAME_REGISTRY     
       FOUNDRY               Ayu
       FAMILY_NAME           Gothic
       WEIGHT_NAME           Medium
       SLANT                 R
       SETWIDTH_NAME         Normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            20
       POINT_SIZE            190
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               C
       AVERAGE_WIDTH         200
       CHARSET_REGISTRY      JISX0208.1990
       CHARSET_ENCODING      0
       FONT                  -Ayu-Gothic-Medium-R-Normal--20-190-75-75-C-200-JISX0208.1990-0
       WEIGHT                10
       RESOLUTION            103
       X_HEIGHT              -2
       QUAD_WIDTH            20
 
 $ 

*** japanese/font-elisa10

 $ xset fp+ /usr/local/share/fonts/elisa10
 $ xlsfonts -fn elisa
 elisa
 $ xlsfonts -ll -fn elisa
 name:  elisa
(snip)
   properties:           21
       FONTNAME_REGISTRY     
       FOUNDRY               Elisa
       FAMILY_NAME           Fixed
       WEIGHT_NAME           Medium
       SLANT                 R
       SETWIDTH_NAME         Normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            10
       POINT_SIZE            70
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               C
       AVERAGE_WIDTH         100
       CHARSET_REGISTRY      JISX0208.1983
       CHARSET_ENCODING      0
       COPYRIGHT             Copyright 1993,1994,1995 (C) by ELISA FONT PJ all rights eserved.
       FONT                  -Elisa-Fixed-Medium-R-Normal--10-70-75-75-C-100-ISX0208.1983-0
       WEIGHT                10
       RESOLUTION            103
       X_HEIGHT              0
       QUAD_WIDTH            10
 
 $ 

*** japanese/font-elisa10

 $ xset fp+ /usr/local/share/fonts/shinonome
 $ xlsfonts -fn k12min
 k12min
 $ xlsfonts -ll -fn k12min
 name:  k12min
(snip)
   properties:           22
       FONTNAME_REGISTRY     
       FOUNDRY               Shinonome
       FAMILY_NAME           Mincho
       WEIGHT_NAME           Medium
       SLANT                 R
       SETWIDTH_NAME         Normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            12
       POINT_SIZE            110
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               C
       AVERAGE_WIDTH         120
       CHARSET_REGISTRY      JISX0208.1990
       CHARSET_ENCODING      0
       COPYRIGHT             Public Domain
       _XMBDFED_INFO         499
       FONT                  -Shinonome-Mincho-Medium-R-Normal--12-110-75-75-C-120-JISX0208.1990-0
       WEIGHT                10
       RESOLUTION            103
       X_HEIGHT              -1
       QUAD_WIDTH            12

 $

* How to fix

(1) Install font files to ${FONTSDIR} instead of ${DATADIR}.
(2) Stop to make symbolic links from the font files to 
    ${PREFIX}/share/fonts/misc/, which is found in the default font path.
(3) Add pkg-message.in to display additional font path settings
    (Copied from head/japanese/k10, r397891 with typo fix).
Comment 1 WATANABE Kazuhiro 2018-03-11 09:25:16 UTC
Created attachment 191385 [details]
A patch for japanese/font-ayu18.
Comment 2 WATANABE Kazuhiro 2018-03-11 09:26:38 UTC
Created attachment 191386 [details]
A patch for japanese/font-ayu20
Comment 3 WATANABE Kazuhiro 2018-03-11 09:28:07 UTC
Created attachment 191387 [details]
A patch for japanese/font-elisa10.
Comment 4 WATANABE Kazuhiro 2018-03-11 09:29:56 UTC
Created attachment 191388 [details]
A patch for japanese/font-shinonome.
Comment 5 WATANABE Kazuhiro 2018-03-11 09:32:37 UTC
Created attachment 191390 [details]
poudriere testport log with the patch (japanese/font-ayu18)
Comment 6 WATANABE Kazuhiro 2018-03-11 09:34:16 UTC
Created attachment 191391 [details]
poudriere testport log with the patch (japanese/font-ayu20)
Comment 7 WATANABE Kazuhiro 2018-03-11 09:35:44 UTC
Created attachment 191394 [details]
poudriere testport log with the patch (japanese/font-elisa10)
Comment 8 WATANABE Kazuhiro 2018-03-11 09:37:09 UTC
Created attachment 191395 [details]
poudriere testport log with the patch (japanese/font-shinonome)
Comment 9 MANTANI Nobutaka freebsd_committer freebsd_triage 2018-04-07 14:36:50 UTC
Sato-san, I have tested these patches and they look fine.
Could you give me your approval to commit them?
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-04-15 13:52:31 UTC
A commit references this bug:

Author: nobutaka
Date: Sun Apr 15 13:52:23 UTC 2018
New revision: 467394
URL: https://svnweb.freebsd.org/changeset/ports/467394

Log:
  - Install font files to ${FONTSDIR} instead of ${DATADIR}.
  - Stop to make symbolic links from the font files to
    ${PREFIX}/share/fonts/misc/, which is found in the default
    font path, because recent libXfont does not follow symbolic
    links.
  - Add pkg-message.in to show additional font path settings.
  - Remove unnecessary pkg-install.in.
  - Bump PORTREVISION.

  PR:		225125 [1], 226511 [2]
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> [2]
  Reported by:	Shigeharu TAKENO <shige@iee.niit.ac.jp> [1]
  Approved by:	maintainer timeout (one month)

Changes:
  head/japanese/font-ayu18/Makefile
  head/japanese/font-ayu18/files/Makefile.in
  head/japanese/font-ayu18/files/pkg-message.in
  head/japanese/font-ayu18/pkg-plist
  head/japanese/font-ayu20/Makefile
  head/japanese/font-ayu20/files/Makefile.in
  head/japanese/font-ayu20/files/pkg-install.in
  head/japanese/font-ayu20/files/pkg-message.in
  head/japanese/font-ayu20/pkg-plist
  head/japanese/font-elisa10/Makefile
  head/japanese/font-elisa10/files/Makefile.in
  head/japanese/font-elisa10/files/pkg-install.in
  head/japanese/font-elisa10/files/pkg-message.in
  head/japanese/font-shinonome/Makefile
  head/japanese/font-shinonome/files/pkg-install.in
  head/japanese/font-shinonome/files/pkg-message.in
  head/japanese/font-shinonome/pkg-plist
Comment 11 MANTANI Nobutaka freebsd_committer freebsd_triage 2018-04-15 13:55:06 UTC
Committed, thanks!