Bug 226516 - [patch][maintainer update] japanese/font-kaname12 japanese/font-naga10: Cannot use the font files with the latest x11-fonts/libXfont
Summary: [patch][maintainer update] japanese/font-kaname12 japanese/font-naga10: Canno...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-11 09:48 UTC by WATANABE Kazuhiro
Modified: 2018-03-25 14:20 UTC (History)
2 users (show)

See Also:


Attachments
A patch for japanese/font-kaname12 (4.53 KB, patch)
2018-03-11 09:49 UTC, WATANABE Kazuhiro
no flags Details | Diff
A patch for japanese/font-naga10 (4.56 KB, patch)
2018-03-11 09:50 UTC, WATANABE Kazuhiro
no flags Details | Diff
poudriere testport log with the patch (japanese/font-kaname12) (20.09 KB, text/plain)
2018-03-11 09:51 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log with the patch (japanese/font-naga10) (34.73 KB, text/plain)
2018-03-11 09:53 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2018-03-11 09:48:25 UTC
As described in bug #225125, japanese/font-kaname12 and japanese/font-naga10
has not been usable since the latest update of x11-fonts/libXfont
(CVE-2017-16611).

Because these ports installs font files as symbolic links,
and the latest x11-fonts/libXfont does not handle other than regular
font files.

* How to repeat
** Without the patch
*** japanese/font-kaname12

 $ pkg info --show-name-only libXfont
 libXfont-1.5.4,2                       # > 1.5.2,2
 $ pkg install ja-font-kaname12
 $ xset fp rehash
 $ xlsfonts -fn k12
 k12
 $ xlsfonts -ll -fn k12
 xlsfonts:  unable to get info about font "k12"
 $ 

*** japanese/font-naga10

 $ pkg install ja-font-naga10
 $ xset fp rehash
 $ xlsfonts -fn k10
 k10
 $ xlsfonts -ll -fn k10
 xlsfonts:  unable to get info about font "k10"
 $ 

** With the patch
*** japanese/font-kaname12

 $ xset fp+ /usr/local/share/fonts/kaname12
 $ xlsfonts -fn k12
 k12
 $ xlsfonts -ll -fn k12
 name:  k12
   direction:            left to right
   indexing:             matrix
   rows:                 0x21 thru 0x74 (33 thru 116)
   columns:              0x21 thru 0x7e (33 thru 126)
   all chars exist:      no
   default char:         0x2121 (8481)
   ascent:               10
   descent:              2
   font type:            Character Cell
   bounds:               width left  right  asc  desc   attr   keysym
         min               12     0     0    -1    -9  0x0000
         max               12     8    12    10     2  0x0000
   properties:           22
       FONTNAME_REGISTRY     
       FOUNDRY               MNKANAME
       FAMILY_NAME           Fixed
       WEIGHT_NAME           Medium
       SLANT                 R
       SETWIDTH_NAME         Normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            12
       POINT_SIZE            110
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               C
       AVERAGE_WIDTH         120
       CHARSET_REGISTRY      JISX0208.1983
       CHARSET_ENCODING      0
       COPYRIGHT             GPL
       WEIGHT                10
       RESOLUTION            103
       X_HEIGHT              -1
       QUAD_WIDTH            12
       _XMBDFED_INFO         343
       FONT                  -MNKANAME-Fixed-Medium-R-Normal--12-110-75-75-C-120-JISX0208.1983-0
 
 $ 

*** japanese/font-naga10

 $ xset fp+ /usr/local/share/fonts/naga10
 $ xlsfonts -fn k10
 k10
 $ xlsfonts -ll -fn k10
 name:  k10
   direction:            left to right
   indexing:             matrix
   rows:                 0x21 thru 0x74 (33 thru 116)
   columns:              0x21 thru 0x7e (33 thru 126)
   all chars exist:      no
   default char:         0x2121 (8481)
   ascent:               8
   descent:              2
   font type:            Character Cell
   bounds:               width left  right  asc  desc   attr   keysym
         min               10     0     0    -1    -7  0x0000
         max               10     7    10     8     2  0x0000
   properties:           22
       FONTNAME_REGISTRY     
       FOUNDRY               Misc
       FAMILY_NAME           Fixed
       WEIGHT_NAME           Medium
       SLANT                 R
       SETWIDTH_NAME         Normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            10
       POINT_SIZE            90
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               C
       AVERAGE_WIDTH         100
       CHARSET_REGISTRY      jisx0208.1983
       CHARSET_ENCODING      0
       COPYRIGHT             Copyright 1998, 1999 (c) NAGAO, Sadakazu.  All rights reserved.
       _XMBDFED_INFO         582
       FONT                  -Misc-Fixed-Medium-R-Normal--10-90-75-75-C-100-jisx0208.1983-0
       WEIGHT                10
       RESOLUTION            103
       X_HEIGHT              -1
       QUAD_WIDTH            10

 $

* How to fix

(1) Install font files to ${FONTSDIR} instead of ${DATADIR}.
(2) Stop to make symbolic links from the font files to 
    ${PREFIX}/share/fonts/misc/, which is found in the default font path.
(3) Revert pkg-message.in to display additional font path settings
    (Copied from head/japanese/k10, r397891 with typo fix).
Comment 1 WATANABE Kazuhiro 2018-03-11 09:49:41 UTC
Created attachment 191398 [details]
A patch for japanese/font-kaname12
Comment 2 WATANABE Kazuhiro 2018-03-11 09:50:46 UTC
Created attachment 191399 [details]
A patch for japanese/font-naga10
Comment 3 WATANABE Kazuhiro 2018-03-11 09:51:58 UTC
Created attachment 191400 [details]
poudriere testport log with the patch (japanese/font-kaname12)
Comment 4 WATANABE Kazuhiro 2018-03-11 09:53:10 UTC
Created attachment 191401 [details]
poudriere testport log with the patch (japanese/font-naga10)
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-03-25 14:08:47 UTC
A commit references this bug:

Author: nobutaka
Date: Sun Mar 25 14:07:49 UTC 2018
New revision: 465516
URL: https://svnweb.freebsd.org/changeset/ports/465516

Log:
  - Install font files to ${FONTSDIR} instead of ${DATADIR}.
  - Stop to make symbolic links from the font files to
    ${PREFIX}/share/fonts/misc/, which is found in the default
    font path, because recent libXfont does not follow symbolic
    links.
  - Add pkg-message.in to show additional font path settings.
  - Remove unnecessary pkg-install.in.
  - Bump PORTREVISION.

  PR:		225125 [1], 226516 [2]
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> (maintainer) [2]
  Reported by:	Shigeharu TAKENO <shige@iee.niit.ac.jp> [1]

Changes:
  head/japanese/font-kaname12/Makefile
  head/japanese/font-kaname12/files/Makefile.in
  head/japanese/font-kaname12/files/pkg-install.in
  head/japanese/font-kaname12/files/pkg-message.in
  head/japanese/font-kaname12/pkg-plist
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-03-25 14:19:03 UTC
A commit references this bug:

Author: nobutaka
Date: Sun Mar 25 14:18:18 UTC 2018
New revision: 465518
URL: https://svnweb.freebsd.org/changeset/ports/465518

Log:
  - Install font files to ${FONTSDIR} instead of ${DATADIR}.
  - Stop to make symbolic links from the font files to
    ${PREFIX}/share/fonts/misc/, which is found in the default
    font path, because recent libXfont does not follow symbolic
    links.
  - Add pkg-message.in to show additional font path settings.
  - Remove unnecessary pkg-install.in.
  - Bump PORTREVISION.

  PR:		225125 [1], 226516 [2]
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> (maintainer) [2]
  Reported by:	Shigeharu TAKENO <shige@iee.niit.ac.jp> [1]

Changes:
  head/japanese/font-naga10/Makefile
  head/japanese/font-naga10/files/Makefile.in
  head/japanese/font-naga10/files/pkg-install.in
  head/japanese/font-naga10/files/pkg-message.in
  head/japanese/font-naga10/pkg-plist
Comment 7 MANTANI Nobutaka freebsd_committer freebsd_triage 2018-03-25 14:20:51 UTC
Commited, thanks!