Bug 226518 - [patch] japanese/font-kappa20: Cannot use the font files with the latest x11-fonts/libXfont
Summary: [patch] japanese/font-kappa20: Cannot use the font files with the latest x11-...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: MANTANI Nobutaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-11 12:19 UTC by WATANABE Kazuhiro
Modified: 2018-03-25 16:14 UTC (History)
3 users (show)

See Also:
nobutaka: maintainer-feedback+


Attachments
A patch for japanese/font-kappa20 (5.90 KB, patch)
2018-03-11 12:20 UTC, WATANABE Kazuhiro
no flags Details | Diff
poudriere testport log with the patch (japanese/font-kappa20) (72.57 KB, text/plain)
2018-03-11 12:21 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2018-03-11 12:19:31 UTC
As described in bug #225125, japanese/font-kappa20 has not been usable
since the latest update of x11-fonts/libXfont (CVE-2017-16611).

Because japanese/font-kappa20 installs font files as symbolic links,
and the latest x11-fonts/libXfont does not handle other than regular
font files.

* How to repeat
** Without the patch

 $ pkg info --show-name-only libXfont
 libXfont-1.5.4,2                       # > 1.5.2,2
 $ pkg install ja-font-kappa20
 $ xset fp rehash
 $ xlsfonts -fn k20m
 k20m
 $ xlsfonts -ll -fn k20m
 xlsfonts:  unable to get info about font "k20m"
 $ 

** With the patch

 $ xset fp+ /usr/local/share/fonts/kappa20
 $ xlsfonts -fn k20m
 k20m
 $ xlsfonts -ll -fn k20m
 name:  k20m
   direction:            left to right
   indexing:             matrix
   rows:                 0x21 thru 0x74 (33 thru 116)
   columns:              0x21 thru 0x7e (33 thru 126)
   all chars exist:      no
   default char:         0x2121 (8481)
   ascent:               17
   descent:              3
   font type:            Character Cell
   bounds:               width left  right  asc  desc   attr   keysym
         min               20     0     0    -2   -16  0x0000
         max               20    14    20    17     3  0x0000
   properties:           21
       COPYRIGHT             public domain
       FONTNAME_REGISTRY     
       FOUNDRY               Kappa
       FAMILY_NAME           Mincho
       WEIGHT_NAME           Medium
       SLANT                 R
       SETWIDTH_NAME         Normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            20
       POINT_SIZE            190
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               C
       AVERAGE_WIDTH         200
       CHARSET_REGISTRY      JISX0208.1990
       CHARSET_ENCODING      0
       FONT                  -Kappa-Mincho-Medium-R-Normal--20-190-75-75-C-200-JISX0208.1990-0
       WEIGHT                10
       RESOLUTION            103
       X_HEIGHT              -2
       QUAD_WIDTH            20
  
 $ 

* How to fix

(1) Install font files to ${FONTSDIR} instead of ${DATADIR}.
(2) Stop to make symbolic links from the font files to 
    ${PREFIX}/share/fonts/misc/, which is found in the default font path.
(3) Add pkg-message.in to display additional font path settings
    (Copied from head/japanese/k10, r397891 with typo fix).
Comment 1 WATANABE Kazuhiro 2018-03-11 12:20:35 UTC
Created attachment 191406 [details]
A patch for japanese/font-kappa20
Comment 2 WATANABE Kazuhiro 2018-03-11 12:21:45 UTC
Created attachment 191407 [details]
poudriere testport log with the patch (japanese/font-kappa20)
Comment 3 ginga-freebsd 2018-03-25 15:39:58 UTC
Thanks for the patch.
port-maintainer approved.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-25 16:14:00 UTC
A commit references this bug:

Author: nobutaka
Date: Sun Mar 25 16:13:32 UTC 2018
New revision: 465526
URL: https://svnweb.freebsd.org/changeset/ports/465526

Log:
  - Install font files to ${FONTSDIR} instead of ${DATADIR}.
  - Stop to make symbolic links from the font files to
    ${PREFIX}/share/fonts/misc/, which is found in the default
    font path, because recent libXfont does not follow symbolic
    links.
  - Add pkg-message.in to show additional font path settings.
  - Remove unnecessary pkg-install.in.
  - Bump PORTREVISION.

  PR:		225125 [1], 226518 [2]
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> [2]
  Reported by:	Shigeharu TAKENO <shige@iee.niit.ac.jp> [1]
  Approved by:	maintainer

Changes:
  head/japanese/font-kappa20/Makefile
  head/japanese/font-kappa20/files/Makefile.in
  head/japanese/font-kappa20/files/pkg-install.in
  head/japanese/font-kappa20/files/pkg-message.in
  head/japanese/font-kappa20/pkg-plist
Comment 5 MANTANI Nobutaka freebsd_committer freebsd_triage 2018-03-25 16:14:42 UTC
Committed, thanks!