Bug 226519 - [patch] japanese/font-mona: Cannot use the font files with the latest x11-fonts/libXfont
Summary: [patch] japanese/font-mona: Cannot use the font files with the latest x11-fon...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-11 12:24 UTC by WATANABE Kazuhiro
Modified: 2018-03-11 15:05 UTC (History)
2 users (show)

See Also:


Attachments
A patch for japanese/font-mona (5.99 KB, patch)
2018-03-11 12:25 UTC, WATANABE Kazuhiro
no flags Details | Diff
A patch for japanese/font-mona (5.99 KB, patch)
2018-03-11 12:46 UTC, WATANABE Kazuhiro
no flags Details | Diff
poudriere testport log with the patch (japanese/font-mona) (378.90 KB, text/plain)
2018-03-11 12:48 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2018-03-11 12:24:33 UTC
As described in bug #225125, japanese/font-mona has not been usable
since the latest update of x11-fonts/libXfont (CVE-2017-16611).

Because japanese/font-mona installs font files as symbolic links,
and the latest x11-fonts/libXfont does not handle other than regular
font files.

* How to repeat
** Without the patch

 $ pkg info --show-name-only libXfont
 libXfont-1.5.4,2                       # > 1.5.2,2
 $ pkg install ja-font-mona
 $ xset fp rehash
 $ xlsfonts -fn monak12
 monak12
 $ xlsfonts -ll -fn monak12
 xlsfonts:  unable to get info about font "monak12"
 $ 

** With the patch

 $ xset fp+ /usr/local/share/fonts/mona
 $ xlsfonts -fn monak12
 monak12
 $ xlsfonts -ll -fn monak12
 name:  monak12
   direction:            left to right
   indexing:             matrix
   rows:                 0x21 thru 0x7c (33 thru 124)
   columns:              0x21 thru 0x7e (33 thru 126)
   all chars exist:      no
   default char:         0x2126 (8486)
   ascent:               10
   descent:              2
   font type:            Proportional (min and max widths not equal)
   bounds:               width left  right  asc  desc   attr   keysym
         min                3     0     3    10     2  0x0000
         max               12     0    12    10     2  0x0000
   properties:           22
       FONTNAME_REGISTRY     
       FOUNDRY               Mona
       FAMILY_NAME           Gothic
       WEIGHT_NAME           Medium
       SLANT                 R
       SETWIDTH_NAME         Normal
       ADD_STYLE_NAME        
       PIXEL_SIZE            12
       POINT_SIZE            110
       RESOLUTION_X          75
       RESOLUTION_Y          75
       SPACING               P
       AVERAGE_WIDTH         120
       CHARSET_REGISTRY      JISX0208.1990
       CHARSET_ENCODING      0
       COPYRIGHT             Public Domain
       _XMBDFED_INFO         499
       FONT                  -Mona-Gothic-Medium-R-Normal--12-110-75-75-P-120-JISX0208.1990-0
       WEIGHT                10
       RESOLUTION            103
       X_HEIGHT              10
       QUAD_WIDTH            7
  
 $ 

* How to fix

(1) Install font files to ${FONTSDIR} instead of ${DATADIR}.
(2) Stop to make symbolic links from the font files to 
    ${PREFIX}/share/fonts/misc/, which is found in the default font path.
(3) Add pkg-message.in to display additional font path settings
    (Copied from head/japanese/k10, r397891 with typo fix).
Comment 1 WATANABE Kazuhiro 2018-03-11 12:25:31 UTC
Created attachment 191408 [details]
A patch for japanese/font-mona
Comment 2 WATANABE Kazuhiro 2018-03-11 12:46:29 UTC
Created attachment 191413 [details]
A patch for japanese/font-mona

The old one has a typo.
Comment 3 WATANABE Kazuhiro 2018-03-11 12:48:28 UTC
Created attachment 191414 [details]
poudriere testport log with the patch (japanese/font-mona)
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-03-11 14:57:48 UTC
A commit references this bug:

Author: nobutaka
Date: Sun Mar 11 14:57:29 UTC 2018
New revision: 464177
URL: https://svnweb.freebsd.org/changeset/ports/464177

Log:
  - Install font files to ${FONTSDIR} instead of ${DATADIR}.
  - Stop to make symbolic links from the font files to
    ${PREFIX}/share/fonts/misc/, which is found in the default
    font path, because recent libXfont does not follow symbolic
    links.
  - Add pkg-message.in to show additional font path settings.
  - Remove unnecessary pkg-install.in.
  - Bump PORTREVISION.

  PR:		225125 [1], 226519 [2]
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp> [2]
  Reported by:	Shigeharu TAKENO <shige@iee.niit.ac.jp> [1]

Changes:
  head/japanese/font-mona/Makefile
  head/japanese/font-mona/files/patch-Makefile
  head/japanese/font-mona/files/pkg-install.in
  head/japanese/font-mona/files/pkg-message.in
  head/japanese/font-mona/pkg-plist
Comment 5 MANTANI Nobutaka freebsd_committer freebsd_triage 2018-03-11 15:05:19 UTC
I have committed your patch. Thanks!