Bug 226584 - security/openvpn v2.4.5 build failure on 11.1S with libressl on amd64 (2.4.4 does build)
Summary: security/openvpn v2.4.5 build failure on 11.1S with libressl on amd64 (2.4.4 ...
Status: Closed DUPLICATE of bug 226568
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on: 226568
Blocks:
  Show dependency tree / graph
 
Reported: 2018-03-13 23:43 UTC by dewayne
Modified: 2018-03-14 06:23 UTC (History)
2 users (show)

See Also:
mandree: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2018-03-13 23:43:16 UTC 
Working within the FreeBSD CoC

FreeBSD 11.1-STABLE  r329008M amd64 1101509 1101509, using libressl

 In file included from crypto_openssl.c:44:
./openssl_compat.h:717:1: error: static declaration of 'SSL_CTX_set_min_proto_version' follows non-static declaration
SSL_CTX_set_min_proto_version(SSL_CTX *ctx, long tls_ver_min)
^
/usr/local/include/openssl/ssl.h:1175:5: note: previous declaration is here
int SSL_CTX_set_min_proto_version(SSL_CTX *ctx, uint16_t version);
    ^
In file included from crypto_openssl.c:44:
./openssl_compat.h:746:1: error: static declaration of 'SSL_CTX_set_max_proto_version' follows non-static declaration
SSL_CTX_set_max_proto_version(SSL_CTX *ctx, long tls_ver_max)
^
/usr/local/include/openssl/ssl.h:1176:5: note: previous declaration is here
int SSL_CTX_set_max_proto_version(SSL_CTX *ctx, uint16_t version);
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-03-13 23:47:55 UTC 
Should solved with recent committed ports r464440.
Comment 2 dewayne 2018-03-13 23:56:11 UTC 
Rectified while this PR was prepared. Thank-you.

However I think you should tweak the PORTREVISION as the produced code has been changed.
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2018-03-14 06:23:42 UTC 
Dewayne, I do not think that a PORTREVISION bump is necessary.

The patch fixes a build that was previously failing (i. e. where no package/build was previously generated, so nothing could change under LibreSSL option), and to me the patch does not look as though it would affect the generated code of OpenSSL- or mbedTLS-based builds.

If someone can show me otherwise (i. e. that a SUCCEEDING build changes generated code - and I do not mean embedded timestamps in the builds, only actual code changes), I will bump PORTREVISION, but not sooner.

*** This bug has been marked as a duplicate of bug 226568 ***