Bug 226635 - editors/openoffice-devel doesn't require bash
Summary: editors/openoffice-devel doesn't require bash
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-15 17:47 UTC by Pedro F. Giffuni
Modified: 2018-03-15 20:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (office)

Attachments
remove bash requirement (546 bytes, patch)
2018-03-15 17:47 UTC, Pedro F. Giffuni 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2018-03-15 17:47:33 UTC 
Created attachment 191526 [details]
remove bash requirement

The bash shell was removed as a requirement to build apache openoffice ages ago.
Comment 1 Don Lewis freebsd_committer freebsd_triage 2018-03-15 18:52:39 UTC 
configure still looks for bash:

dnl ===================================================================
dnl Check whether the bash shell can be used.
dnl ===================================================================
AC_PATH_PROG(SHELLPATH, bash)
if test -z "$SHELLPATH"; then
   AC_MSG_ERROR([bash not found in \$PATH])
else
   SHELLPATH=`echo $SHELLPATH | $SED -n "s/\/bash$//p"`
fi
Comment 2 Don Lewis freebsd_committer freebsd_triage 2018-03-15 18:56:36 UTC 
... and that gets used to set $OOO_SHELL:

# 3. shell path.
if ( $platform =~ m/os2/ )
{
$OOO_SHELL = 'sh';
}
else
{
$OOO_SHELL = '@SHELLPATH@'."\/bash";
}
Comment 3 Pedro F. Giffuni freebsd_committer freebsd_triage 2018-03-15 20:19:09 UTC 
Bah... I removed all the invocations upstream but there are obviously some leftovers.

Thanks for pointing those out.