Created attachment 191600 [details] Patch fixing formatting of the pkg-descr in sysutils/py-plumbum Changes: - Capitalize Python in COMMENT - Fix misformatted pkg-descr
Approved, would you like to commit this change? If so please rememeber to bump portrevision. Otherwise I'll happily commit this. Thank you for improving plumbum.
(In reply to David Naylor from comment #1) I'd love to commit this change but I've not got a chance to be a committer yet :) I think I'll have to leave this patch to you. Also, I didn't bump the port revision as there is nothing to rebuild and I didn't want to make people have to rebuild this port.
(In reply to Mateusz Piotrowski from comment #2) The current [1] definitional requirement for PORTREVISION bumps is: "PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way" [1], with some listed exceptions. Though not precisely listed or mentioned, this change could plausibly be argued to come under the following exception: "Style changes to the port skeleton with no functional change to what appears in the resulting package." [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-naming (Section 5.2.3.1 - PORTREVISION)
Created attachment 191631 [details] Patch fixing formatting of the pkg-descr in sysutils/py-plumbum (with a bumped portrevision) I'm submitting an alternative patch with the port revision bumped just in case. :)
A commit references this bug: Author: dbn Date: Sat Jun 2 16:32:38 UTC 2018 New revision: 471377 URL: https://svnweb.freebsd.org/changeset/ports/471377 Log: sysutils/py-plumbum: fix comment and pkg-descr PR: 226697 Submitted by: 0mp Changes: head/sysutils/py-plumbum/Makefile head/sysutils/py-plumbum/pkg-descr
My sincere apologies, I somehow thought this was already committed. I've just done so now. Thank you for the patch :-)
(In reply to David Naylor from comment #6) No worries :) I'm glad that you've found my patch useful.