Bug 226715 - x11/rofi: update to v1.5.1 (PATCH)
Summary: x11/rofi: update to v1.5.1 (PATCH)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-19 07:17 UTC by Alexandre C. Guimarães
Modified: 2018-03-20 11:35 UTC (History)
2 users (show)

See Also:
nomoo: maintainer-feedback+


Attachments
Updating to v1.5.1. (1.51 KB, patch)
2018-03-19 07:17 UTC, Alexandre C. Guimarães
tobik: maintainer-approval? (nomoo)
Details | Diff
Update to v1.5.1. (2.40 KB, patch)
2018-03-19 17:23 UTC, Alexandre C. Guimarães
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre C. Guimarães freebsd_committer 2018-03-19 07:17:15 UTC
Created attachment 191617 [details]
Updating to v1.5.1.

Hi.

I attach a patch to update x11/rofi to version 1.5.1.

Thanks!
Comment 1 Alexandre C. Guimarães freebsd_committer 2018-03-19 17:23:27 UTC
Created attachment 191635 [details]
Update to v1.5.1.

- update to v1.5.1
- switch to use GitHub variables

Cheers!
Comment 2 Tobias Kortkamp freebsd_committer 2018-03-19 17:54:58 UTC
(In reply to Alexandre C. Guimarães from comment #1)
This is wrong.  Please revert and use the tarball they publish instead.
We should always use them when upstream has taken the time to actually create
them.  They have pregenerated configure scripts and other goodies.

There was a thread on the OpenBSD ports mailing list about this as well.
This applies to FreeBSD too.

https://marc.info/?l=openbsd-ports&m=151973450514279&w=2
Comment 3 Tobias Kortkamp freebsd_committer 2018-03-19 18:04:53 UTC
Comment on attachment 191617 [details]
Updating to v1.5.1.

Testbuilds of the first patch were fine, so now waiting for maintainer approval.
Comment 4 Alexandre C. Guimarães freebsd_committer 2018-03-19 18:09:05 UTC
Thanks! :-)
Comment 5 nomoo 2018-03-20 10:22:21 UTC
Seems fine. Thanks, Alexandre, Tobias.
Comment 6 Tobias Kortkamp freebsd_committer 2018-03-20 11:34:54 UTC
Committed. Thanks!
Comment 7 commit-hook freebsd_committer 2018-03-20 11:35:02 UTC
A commit references this bug:

Author: tobik
Date: Tue Mar 20 11:34:43 UTC 2018
New revision: 465082
URL: https://svnweb.freebsd.org/changeset/ports/465082

Log:
  x11/rofi: Update to 1.5.1

  Changes:	https://github.com/DaveDavenport/rofi/releases/tag/1.5.1
  PR:		226715
  Submitted by:	Alexandre C. Guimar?es <lebarondemerde@privacychain.ch>
  Approved by:	nomoo@nomoo.ru (maintainer)

Changes:
  head/x11/rofi/Makefile
  head/x11/rofi/distinfo
  head/x11/rofi/pkg-plist