Bug 226747 - databases/py-carbon: update to 1.1.2
Summary: databases/py-carbon: update to 1.1.2
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL: https://people.FreeBSD.org/~sunpoet/p...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-19 19:11 UTC by Po-Chuan Hsieh
Modified: 2018-03-23 13:44 UTC (History)
1 user (show)

See Also:
swills: maintainer-feedback-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-03-19 19:11:07 UTC 
Update to 1.1.2

- Change MASTER_SITES to CHEESESHOP
- Update RUN_DEPENDS: use Django metaport (www/py-django)
- Relax USES=python

Changes:        https://github.com/graphite-project/carbon/releases
Comment 1 Steve Wills freebsd_committer freebsd_triage 2018-03-20 20:22:13 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #0)
I would prefer to keep the master site using GitHUb.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-03-21 19:41:34 UTC 
Add koobs@ to Cc list.

I remember that CHEESESHOP is preferred unless it has problem.
Comment 3 Steve Wills freebsd_committer freebsd_triage 2018-03-22 17:24:11 UTC 
Port was updated.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-03-22 18:33:26 UTC 
You missed:
- Relax USES=python: it is 3.x compatible [1]
- RUN_DEPENDS:
  - cachetools and urllib3 are missing [2]
  - r465298 adds security/py-service_identity but I cannot find where it came from?

[1]
https://pypi.python.org/pypi/carbon/1.1.2

[2]
from setup.py:
install_requires=['Twisted', 'txAMQP', 'cachetools', 'urllib3'],
Comment 5 Steve Wills freebsd_committer freebsd_triage 2018-03-22 20:50:25 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #4)
security/py-service_identity came from runtime testing. Please test and then send an updated patch.
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-03-23 09:20:40 UTC 
(In reply to Steve Wills from comment #5)
Sorry, I did not do runtime testing but only do build time check.
You've added cachetools and urllib3 to RUN_DEPENDS in r465316.
Can you also change USES=python:2.7 to USES=python?
Thanks!
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-03-23 09:56:54 UTC 
I've updated the patch against r465316.
Comment 8 Steve Wills freebsd_committer freebsd_triage 2018-03-23 13:27:03 UTC 
When stopping the service via "service carbon stop", this produces:

/usr/local/etc/rc.d/carbon: WARNING: $command_interpreter /usr/local/bin/python2.7 != /usr/local/bin/python3.6

Please test!
Comment 9 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-03-23 13:44:37 UTC 
The interpreter is hardcoded in the rc.d script which should be PYTHON_CMD.

command_interpreter="%%PREFIX%%/bin/python2.7"

But don't mind, I do not use this port and I give up this PR.