Bug 226790 - mail/alpine: update to v2.21.1 (patch).
Summary: mail/alpine: update to v2.21.1 (patch).
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
: 226810 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-03-19 21:34 UTC by Alexandre C. Guimarães
Modified: 2018-03-21 22:41 UTC (History)
2 users (show)

See Also:
rigoletto: maintainer-feedback? (mbeis)


Attachments
Updating mail/alpine to version 2.21.1. (2.95 KB, patch)
2018-03-19 21:34 UTC, Alexandre C. Guimarães
no flags Details | Diff
Updating to 2.21.1 (2.97 KB, patch)
2018-03-20 16:58 UTC, Alexandre C. Guimarães
no flags Details | Diff
Updating to v2.21.1. (2.95 KB, patch)
2018-03-20 20:25 UTC, Alexandre C. Guimarães
no flags Details | Diff
Updating to v2.21.1. (2.93 KB, patch)
2018-03-20 20:28 UTC, Alexandre C. Guimarães
no flags Details | Diff
mail/alpine update to 2.21.1 (2.82 KB, patch)
2018-03-20 22:33 UTC, Marco Beishuizen
mbeis: maintainer-approval+
Details | Diff
mail/alpine update to 2.21.1 (2.72 KB, patch)
2018-03-21 07:37 UTC, Marco Beishuizen
mbeis: maintainer-approval+
Details | Diff
mail/alpine update to 2.21.1 (3.14 KB, patch)
2018-03-21 12:11 UTC, Marco Beishuizen
mbeis: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-03-19 21:34:11 UTC
Created attachment 191644 [details]
Updating mail/alpine to version 2.21.1.

Hi.

- update to version 2.21.1
- update MASTER_SITES (the old is gone)
- Maildir OPTION removed (source gone)
- update WWW to the new address

Cheers! :-)
Comment 1 Marco Beishuizen 2018-03-20 16:12:09 UTC
Hi Alexandre,

Thanks for the patch. I'm aware of the missing master site of Alpine. The upstream developer (Eduardo Chappa) is currently trying to find a new host, but this takes some time.

I'm also aware of the existence of the git site. What I didn't know is how to use the git site for the FreeBSD port, so thanks for that. I'll try to update the Alpine port to 2.21.1 with the git site.

I'm a little bit hesitant of removing the maildir patch because it's possible that a lot of Alpine users are using it. But on the other hand if the sources stay gone, then removing it is the only option. So I'll probably remove it for the time being, and maybe the upstream patch reappears again and I can put it back.

Also I can't remove the gettext-runtime dependency because textproc-aspell and editors/pico depend on it.

Regards,
Marco
Comment 2 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-03-20 16:34:05 UTC
Hi.

I was also wondering about the maildir feature, I would need of that if I used Alpine. However, I considered the possibility of that being imported, IDK. :)

I removed 'gettext-runtime:run' to make some tests and forgot to add it again.

Well, he can use GitHub or GitLab. :D

Cheers!
Comment 3 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-03-20 16:58:55 UTC
Created attachment 191662 [details]
Updating to 2.21.1

Bring gettext-runtime back.

If you still have the patch source, I think it would be justifiable if you host it somewhere, update the current port (2.21) with that new source home, and add to pkg-message the patch is not supported upstream anymore and may not be available in a near future.

That would give users time to re-organize.

However, if the patch still build against 2.21.1 (or if not but you can make it) you could keep it until not possible anymore. Just let the users be aware of.

Cheers!
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-20 20:04:08 UTC
Comment on attachment 191662 [details]
Updating to 2.21.1

If this must use the Git repository please use the ?dummy= trick, so
that the distfile gets a proper filename i.e. remove DISTNAME again
and set

MASTER_SITES=	http://repo.or.cz/alpine.git/snapshot/${GIT_COMMIT}${EXTRACT_SUFX}?dummy=/
Comment 5 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-03-20 20:25:44 UTC
Created attachment 191669 [details]
Updating to v2.21.1.

Done.
Comment 6 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-03-20 20:28:00 UTC
Created attachment 191670 [details]
Updating to v2.21.1.

Just cleaning.
Comment 7 Marco Beishuizen 2018-03-20 22:33:09 UTC
Created attachment 191674 [details]
mail/alpine update to 2.21.1

- Update to new version 2.21.1
- New master site http://repo.or.cz/alpine.git (old one is gone)
- The maildir option is removed for now. If the package reappears, we can always add it again
- Update of slave port editors/pico-alpine
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-20 22:56:11 UTC
Comment on attachment 191674 [details]
mail/alpine update to 2.21.1

The patch seems to be missing the update to editors/pico-alpine, or the
PORTNAME, CATEGORIES, COMMENT variables need to keep ?= like before so
that the slave port can override them.
Comment 9 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-20 23:13:22 UTC
(In reply to Tobias Kortkamp from comment #8)
I see now that you've opened bug #226810 for pico-alpine.  Can you please keep
the patches to it in this PR only?  Whatever we do to mail/alpine will also
affect editors/pico-alpine.  My comment about ?= for the slave port still
applies regardless.
Comment 10 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-20 23:13:33 UTC
*** Bug 226810 has been marked as a duplicate of this bug. ***
Comment 11 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-03-20 23:29:05 UTC
These ports can easily become flavored, but I do not know if it is possible to have flavors in different categories, I guess not.

Flavored ports what bring new packages should wait ports-mgmt/poudriere-3.3 come out, but I do not know about moving between categories, if that would be the case.
Comment 12 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-03-20 23:44:05 UTC
Well, a flavored version of 'pico-alpine' would automatically be called 'alpine-pico', and so it would fall in the ports-mgmt/poudriere-3.3 rule.
Comment 13 Marco Beishuizen 2018-03-21 07:37:12 UTC
Created attachment 191686 [details]
mail/alpine update to 2.21.1

Patch for the update with "?=" restored.
Comment 14 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-21 09:10:31 UTC
The commit we use now [1] seems to actually be for version 2.21 not 2.21.1...
So right now this update is a no-op.

[1] http://repo.or.cz/alpine.git/commit/672d6838a9babf2faeb9f79267525a4ab9d20b14
Comment 15 Marco Beishuizen 2018-03-21 12:11:37 UTC
Created attachment 191702 [details]
mail/alpine update to 2.21.1

Patch with update to the correct version.
Comment 16 commit-hook freebsd_committer freebsd_triage 2018-03-21 22:40:29 UTC
A commit references this bug:

Author: tobik
Date: Wed Mar 21 22:40:08 UTC 2018
New revision: 465245
URL: https://svnweb.freebsd.org/changeset/ports/465245

Log:
  mail/alpine: Update to 2.21.1

  - Move to new master site.  The old one is gone.
  - The maildir patch is gone too, so remove the MAILDIR option for now.
  - While here add LICENSE_FILE and fix plist

  PR:		226790
  Submitted by:	Alexandre C. Guimar?es <lebarondemerde@privacychain.ch>
  Approved by:	Marco Beishuizen <mbeis@xs4all.nl> (maintainer)

Changes:
  head/mail/alpine/Makefile
  head/mail/alpine/distinfo
  head/mail/alpine/pkg-descr
  head/mail/alpine/pkg-plist
Comment 17 Tobias Kortkamp freebsd_committer freebsd_triage 2018-03-21 22:41:17 UTC
Committed. Thanks!