Bug 226922 - www/nghttp2: Fix build without NPN and with LibreSSL 2.7
Summary: www/nghttp2: Fix build without NPN and with LibreSSL 2.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/nghttp2/nghttp2/pu...
Keywords: needs-qa, patch
Depends on:
Blocks: 226843
  Show dependency tree / graph
 
Reported: 2018-03-25 17:59 UTC by Bernard Spil
Modified: 2018-04-03 17:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
svn diff for www/nghttp2 (28.43 KB, patch)
2018-03-25 17:59 UTC, Bernard Spil 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer freebsd_triage 2018-03-25 17:59:17 UTC 
Created attachment 191810 [details]
svn diff for www/nghttp2

```
www/nghttp2: Fix build without NPN and with LibreSSL 2.7

 - The openssl-devel port has NPN disabled
 - LibreSSL 2.7 implements OpenSSL 1.1 API

See also: https://github.com/nghttp2/nghttp2/pull/1152
See also: https://github.com/nghttp2/nghttp2/pull/1153

PR:
Approved by: (maintainer)
```
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-04-03 05:07:17 UTC 
This PR is blocked by libevent.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-04-03 05:11:01 UTC 
(In reply to Sunpoet Po-Chuan Hsieh from comment #1)

Remove "Depends on: 226900".
This can be committed independently though it will not work without bug #226900.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-04-03 09:46:59 UTC 
A commit references this bug:

Author: sunpoet
Date: Tue Apr  3 09:46:33 UTC 2018
New revision: 466298
URL: https://svnweb.freebsd.org/changeset/ports/466298

Log:
  Fix build with LibreSSL 2.7

  PR:		226922
  Submitted by:	brnrd

Changes:
  head/www/nghttp2/files/patch-examples-client.c
  head/www/nghttp2/files/patch-examples-libevent-client.c
  head/www/nghttp2/files/patch-examples-libevent-server.c
  head/www/nghttp2/files/patch-src-HttpServer.cc
  head/www/nghttp2/files/patch-src-asio_common.cc
  head/www/nghttp2/files/patch-src-h2load.cc
  head/www/nghttp2/files/patch-src-nghttp.cc
  head/www/nghttp2/files/patch-src-shrpx_client_handler.cc
  head/www/nghttp2/files/patch-src-shrpx_config.cc
  head/www/nghttp2/files/patch-src-shrpx_connection.cc
  head/www/nghttp2/files/patch-src-shrpx_http2_session.cc
  head/www/nghttp2/files/patch-src-shrpx_live_check.cc
  head/www/nghttp2/files/patch-src-shrpx_tls.cc
  head/www/nghttp2/files/patch-src-ssl_compat.h
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-04-03 10:00:59 UTC 
Committed. Thanks!
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2018-04-03 17:05:16 UTC 
Upstream imported the patch, you'll likely have to remove these patch files again for 1.32.0