Bug 226969 - net-mgmt/vidalia: Fix build with recent clang
Summary: net-mgmt/vidalia: Fix build with recent clang
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-27 10:55 UTC by Fabian Keil
Modified: 2018-11-16 20:30 UTC (History)
1 user (show)

See Also:


Attachments
net-mgmt/vidalia: Fix build with recent clang (2.00 KB, patch)
2018-03-27 10:55 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2018-03-27 10:55:23 UTC
Created attachment 191865 [details]
net-mgmt/vidalia: Fix build with recent clang

The attached patch lets vidalia build again with recent clang versions.

Previously the build failed with messages like:
src/tools/ts2po/ts2po.cpp:51:43: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  header.append("\"Report-Msgid-Bugs-To: "TS2PO_CONTACT_ADDR"\\n\"\n");
                                          ^
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2018-06-08 19:37:22 UTC
I tested your patch, but it fails on head:

/usr/bin/c++  -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_XML_LIB -isystem /usr/local/include/qt4 -isystem /usr/local/include/qt4/QtGui -isystem /usr/local/include/qt4/QtXml -isystem /usr/local/include/qt4/QtNetwork -isystem /usr/local/include/qt4/QtCore -I. -I/usr/local/include/qt4/QtDeclarative -I/usr/local/include/qt4/QtSql -I/usr/local/include/qt4/QtOpenGL -I/usr/local/include/qt4/QtXmlPatterns -I/usr/local/include/qt4/QtWebKit -I/usr/local/include/qt4/QtHelp -I/usr/local/include/qt4/QtScript -I/usr/local/include/qt4/QtSvg -I/usr/local/share/qt4/mkspecs/default -Isrc -Isrc/torcontrol -Isrc/common -Isrc/miniupnpc -Isrc/vidalia -Isrc/vidalia/about -Isrc/vidalia/bwgraph -Isrc/vidalia/config -Isrc/vidalia/help/browser -Isrc/vidalia/log -Isrc/vidalia/network -O2 -pipe -fstack-protector -fno-strict-aliasing -O2 -pipe -fstack-protector -fno-strict-aliasing -MD -MT src/vidalia/CMakeFiles/vidalia.dir/network/moc_NetViewer.o -MF src/vidalia/CMakeFiles/vidalia.dir/network/moc_NetViewer.o.d -o src/vidalia/CMakeFiles/vidalia.dir/network/moc_NetViewer.o -c src/vidalia/network/moc_NetViewer.cxx
In file included from src/vidalia/network/moc_NetViewer.cxx:9:
In file included from src/vidalia/network/NetViewer.h:22:
In file included from src/vidalia/network/GeoIpResolver.h:20:
In file included from src/vidalia/Vidalia.h:21:
In file included from src/vidalia/config/TorSettings.h:19:
In file included from src/vidalia/config/AbstractTorSettings.h:20:
In file included from src/torcontrol/TorControl.h:23:
src/torcontrol/TorSignal.h:16:9: warning: '_TORSIGNAL_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef _TORSIGNAL_H
        ^~~~~~~~~~~~
src/torcontrol/TorSignal.h:17:9: note: '_TORSGINAL_H' is defined here; did you mean '_TORSIGNAL_H'?
#define _TORSGINAL_H
        ^~~~~~~~~~~~
        _TORSIGNAL_H
In file included from src/vidalia/network/moc_NetViewer.cxx:9:
In file included from src/vidalia/network/NetViewer.h:22:
In file included from src/vidalia/network/GeoIpResolver.h:20:
In file included from src/vidalia/Vidalia.h:21:
src/vidalia/config/TorSettings.h:80:38: error: cannot combine with previous 'bool' declaration specifier
  void setAutoControlPort(const bool auto);
                                     ^
1 warning and 1 error generated.


Could you investigate this?

You can find the full log here:

https://people.freebsd.org/~madpilot/vidalia-0.2.21.log
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2018-11-16 20:30:21 UTC
Expired port removed.