Bug 227066 - [MAINTAINER] www/py-django-js-asset: fix for RUN_DEPENDS
Summary: [MAINTAINER] www/py-django-js-asset: fix for RUN_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-29 14:31 UTC by Kai Knoblich
Modified: 2018-03-29 16:23 UTC (History)
1 user (show)

See Also:
kai: maintainer-feedback+


Attachments
py-django-js-asset_RUN_DEPENDS.patch (675 bytes, patch)
2018-03-29 14:31 UTC, Kai Knoblich
kai: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer 2018-03-29 14:31:41 UTC
Created attachment 191928 [details]
py-django-js-asset_RUN_DEPENDS.patch

Hello,

attached is a patch that fixes RUN_DEPENDS to use www/py-django18 instead of the www/py-django meta port which defaults to v1.11.

The port py-django-js-asset is required by www/py-django-mptt and was assigned to it in r465823 and was deassigned in r465876 due build failures.

The patch offers a remedy for that problem. I'll reopen PR #227032 (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227032) in a few minutes to reassign the port as dependency for www/py-django-mptt.

QA:
~~~
For port itself:
poudriere -> (11.1-RELEASE amd64 + i386) for each py27 and py36 flavors -> OK
portlint -> OK

Build tests with ports that depend on py-django-mptt:

www/py-django-cms:
poudriere -> (11.1-RELEASE amd64 + i386) for the py27 flavor -> OK

www/py-django-dpaste
poudriere -> (11.1-RELEASE amd64 + i386) for each py27 and py36 flavor -> OK

--
Cheers
Kai
Comment 1 Yuri Victorovich freebsd_committer 2018-03-29 15:15:48 UTC
Interesting, I am wondering how can people even use django if different parts depend on 3 incompatible versions of www/django. One first needs to choose which 1/3 does he need? -)
Comment 2 Yuri Victorovich freebsd_committer 2018-03-29 15:39:02 UTC
Kai,

Why did you write
> ${PYTHON_SITELIBDIR}/django/bin/django-admin.py:www/py-django18@${FLAVOR} # >= 1.8
and not
> ${PYTHON_PKGNAMEPREFIX}django18>0:www/py-django18@${FLAVOR}
?
Comment 3 Kai Knoblich freebsd_committer 2018-03-29 15:57:03 UTC
(In reply to Yuri Victorovich from comment #2)

I've used that line from www/py-django-mptt's Makefile. But 

> ${PYTHON_PKGNAMEPREFIX}django18>0:www/py-django18@${FLAVOR}

seems a better way for it. Shall I send you a revised patch for it?
Comment 4 Yuri Victorovich freebsd_committer 2018-03-29 16:02:52 UTC
(In reply to Kai from comment #3)

No, it's ok.
Comment 5 Yuri Victorovich freebsd_committer 2018-03-29 16:23:06 UTC
Committed, thanks!
Comment 6 commit-hook freebsd_committer 2018-03-29 16:23:19 UTC
A commit references this bug:

Author: yuri
Date: Thu Mar 29 16:22:53 UTC 2018
New revision: 465906
URL: https://svnweb.freebsd.org/changeset/ports/465906

Log:
  www/py-django-js-asset: Change RUN_DEPENDS py-django -> py-django18 for other port's RUN_DEPENDS

  This is for bug#227032 (www/py-django-mptt) update.

  PR:		227066
  Submitted by:	Kai <freebsd_ports@k-worx.org>

Changes:
  head/www/py-django-js-asset/Makefile