Bug 227087 - x11/gnome-terminal fails to build with gcc
Summary: x11/gnome-terminal fails to build with gcc
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-29 19:48 UTC by Justin Hibbits
Modified: 2019-01-06 08:29 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer freebsd_triage 2018-03-29 19:48:11 UTC 
When building x11/gnome-terminal on a powerpc64 the following errors show up:

cc -DHAVE_CONFIG_H -I. -I..  -I.. -DTERMINAL_COMPILATION -DTERMINAL_CLIENT -DLOCALEDIR="\"/usr/local/share/locale\"" -DGETTEXT_PACKAGE=\"gnome-terminal\"  -isystem /usr/local/include --include config.h -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include/gtk-3.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libdrm -I/usr/local/include/libpng16 -I/usr/local/include/harfbuzz -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/atk-1.0 -I/usr/local/include/at-spi2-atk/2.0 -I/usr/local/include/at-spi-2.0 -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include -I/usr/local/include/dconf -I/usr/local/include/uuid -D_THREAD_SAFE -pthread   -Wno-cast-qual -Wno-format-nonliteral -Wno-suggest-attribute=format -Wno-unused-but-set-variable -Wno-unused-function -Wno-unused-variable -Wno-write-strings  -O2 -pipe  -isystem /usr/local/include -fno-strict-aliasing -MT gterminal-gterminal.o -MD -MP -MF .deps/gterminal-gterminal.Tpo -c -o gterminal-gterminal.o `test -f 'gterminal.c' || echo './'`gterminal.c
cc1: error: unrecognized command line option "-Wno-suggest-attribute=format"
cc1: error: unrecognized command line option "-Wno-unused-but-set-variable"


This could be mitigated by using gcc from ports, or removing those two arguments from the Makefile (via Makefile.am or Makefile.in).
Comment 1 Ting-Wei Lan 2018-04-01 09:52:40 UTC 
It looks like these options are only used when compiling an uninstalled vala program called 'gterminal'. Since gterminal is never installed into the system, I think we can simply pass '--disable-gterminal' to configure to disable the build of it. gterminal has been removed in GNOME Terminal 3.28.0.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-06 08:29:02 UTC 
x11/gnome-terminal is at 3.28.2 now, so closing per comment #1.