Bug 227095 - sysutils/synergy: Install sample conf and make it read from ${PREFIX}/etc
Summary: sysutils/synergy: Install sample conf and make it read from ${PREFIX}/etc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-03-29 21:56 UTC by Vidar Karlsen
Modified: 2018-03-29 23:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
svn diff (1.96 KB, patch)
2018-03-29 21:56 UTC, Vidar Karlsen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vidar Karlsen 2018-03-29 21:56:32 UTC
Created attachment 191959 [details]
svn diff

I propose the following changes to this port:
- Set the etc dir to ${PREFIX}/etc instead of /etc (hardcoded upstream). Without this, we have to put the config in /etc or specify the path/file on the command line.
- Install a sample config file via the @sample way. I picked the .example-basic because it seems most appropriate.

Testbuild ok on 11.1-amd64, 11.1-i386, 10.4-amd64, 10.3-amd64.
portlint -C: looks fine.
Comment 1 Yuri Victorovich freebsd_committer 2018-03-29 23:06:17 UTC
Committed with some changes.
Thank you for the patch!
Comment 2 commit-hook freebsd_committer 2018-03-29 23:07:03 UTC
A commit references this bug:

Author: yuri
Date: Thu Mar 29 23:06:10 UTC 2018
New revision: 465935
URL: https://svnweb.freebsd.org/changeset/ports/465935

Log:
  sysutils/synergy: Install config file under ${PREFIX}/etc

  Also move plist to pkg-plist.

  PR:		227095
  Submitted by:	Vidar Karlsen <vidar@karlsen.tech>

Changes:
  head/sysutils/synergy/Makefile
  head/sysutils/synergy/pkg-plist