Bug 227200 - security/putty: Restore GTK2 frontend support
Summary: security/putty: Restore GTK2 frontend support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords: easy, feature, needs-qa
Depends on:
Blocks:
 
Reported: 2018-04-02 10:49 UTC by Miroslav Lachman
Modified: 2018-04-02 21:30 UTC (History)
0 users

See Also:
mandree: maintainer-feedback+


Attachments
Patch to add suport for GTK2 (2.01 KB, patch)
2018-04-02 10:49 UTC, Miroslav Lachman
no flags Details | Diff
poudriere testport build log - no GTK (33.38 KB, text/plain)
2018-04-02 10:51 UTC, Miroslav Lachman
no flags Details
poudriere testport build log - GTK2 (126.09 KB, text/plain)
2018-04-02 10:52 UTC, Miroslav Lachman
no flags Details
poudriere testport build log - GTK3 (150.40 KB, text/plain)
2018-04-02 10:52 UTC, Miroslav Lachman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Lachman 2018-04-02 10:49:09 UTC
Created attachment 192097 [details]
Patch to add suport for GTK2

security/putty as of version 0.69 was converted to GTK3 only (in FreeBSD ports) but I didn't find any evidence on Putty website that GTK2 support was dropped so I tried to build it with GTK2 and it works for me. GTK3 version has some scrolling problems in KDE4 for me.

I created patch for the port to allow users to choose between GTK2 / GTK3 / no toolkit.

I did poudriere testport for all of these 3 options. It builds fine. Run test for GTK3 / GTK2.
Comment 1 Miroslav Lachman 2018-04-02 10:51:34 UTC
Created attachment 192098 [details]
poudriere testport build log - no GTK
Comment 2 Miroslav Lachman 2018-04-02 10:52:05 UTC
Created attachment 192099 [details]
poudriere testport build log - GTK2
Comment 3 Miroslav Lachman 2018-04-02 10:52:24 UTC
Created attachment 192100 [details]
poudriere testport build log - GTK3
Comment 4 commit-hook freebsd_committer 2018-04-02 21:30:00 UTC
A commit references this bug:

Author: mandree
Date: Mon Apr  2 21:29:17 UTC 2018
New revision: 466267
URL: https://svnweb.freebsd.org/changeset/ports/466267

Log:
  Reinstate support for GTK2 (rather than GTK3) as an OPTION.

  While here, add a putty-gtk2 slave port and update _CONFLICTS.

  Since the default package does not change, and pkg would handle conflicts
  around attempted installation of the new -gtk2 package, omit the
  PORTREVISION bump from Miroslav's original patch.

  PR:		227200
  Submitted by:	Miroslav Lachman

Changes:
  head/security/Makefile
  head/security/putty/Makefile
  head/security/putty-gtk2/
  head/security/putty-gtk2/Makefile
  head/security/putty-nogtk/Makefile
Comment 5 Matthias Andree freebsd_committer 2018-04-02 21:30:09 UTC
Committed with minor changes, thank you!