Bug 227220 - archivers/snappy: Update to 1.1.7
Summary: archivers/snappy: Update to 1.1.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords: needs-qa
Depends on:
Blocks: 242002
  Show dependency treegraph
 
Reported: 2018-04-02 23:53 UTC by Thaddeus Covert
Modified: 2019-11-23 15:41 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vanilla)


Attachments
patch from top of recent checkout (2.78 KB, patch)
2018-04-02 23:53 UTC, Thaddeus Covert
tcovert+freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thaddeus Covert 2018-04-02 23:53:45 UTC
Created attachment 192134 [details]
patch from top of recent checkout

Updating snappy to current version. Distribution has moved to cmake from gnu configure.

NOTE: There seems to be no static library built with the dynamic libraries with the new 1.1.7 build.

Testing that's been done:
cd ~                                                                                                                                                                                                     
git clone https://github.com/freebsd/freebsd-ports.git ports                                                                                                                                             
cd archivers/snappy                                                                                                                                                                                      
#https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook                                                                                                                                      
echo DEVELOPER=yes >> /etc/make.conf                                                                                                                                                                     
# make changes in /home/user/ports/archivers/snappy                                                                                                                                                                                           
make makesum                                                                                                                                                                                             
make makeplist                                                                                                                                                                                           
make clean                                                                                                                                                                                               
make describe                                                                                                                                                                                            
make extract                                                                                                                                                                                             
portlint -A                                                                                                                                                                                              
make clean; make package PREFIX=/var/tmp`make -V snappy`                                                                                                                                                 
make check-plist                                                                                                                                                                                         
                                                                                                                                                                                                         
sudo pkg install porttools                                                                                                                                                                               
sudo pkg install portlint                                                                                                                                                                                
port test /home/user/ports/archivers/snappy                                                                                                                                                              
poudriere testport -j 11_1-STABLE -p development -i -o archivers/snappy                                                                                                                                  
poudriere testport -j 11_1-STABLE -p development -i -o archivers/py-python-snappy                                                                                                                        
                                                                                                                                                                                                         git diff
Comment 1 Vanilla I. Shu freebsd_committer 2018-04-05 02:43:13 UTC
Hi:

patch seems fine to me,

but there are many ports depending on old style pkg-config base snappy.

so we need to take care backward compatible.
Comment 2 commit-hook freebsd_committer 2019-11-23 15:41:02 UTC
A commit references this bug:

Author: vanilla
Date: Sat Nov 23 15:40:09 UTC 2019
New revision: 518247
URL: https://svnweb.freebsd.org/changeset/ports/518247

Log:
  1: update to 1.1.7.
  2: install snappy.pc for backward compatible.

  PR:		227220
  Submitted by:	tcovert+freebsd@sahuagin.net

Changes:
  head/archivers/snappy/Makefile
  head/archivers/snappy/distinfo
  head/archivers/snappy/files/
  head/archivers/snappy/files/snappy.pc.in
  head/archivers/snappy/pkg-plist