Bug 227221 - databases/arangodb33: Adapt ${name}_limits to the new resource limiting mechanics for services
Summary: databases/arangodb33: Adapt ${name}_limits to the new resource limiting mecha...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch-ready, regression
Depends on:
Blocks: 227205
  Show dependency tree / graph
 
Reported: 2018-04-02 23:57 UTC by Mateusz Piotrowski
Modified: 2018-06-09 19:27 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback-

Attachments
Patch adding support for the new ${name}_limits mechanics (databases/arangodb33) (2.85 KB, patch)
2018-04-02 23:57 UTC, Mateusz Piotrowski 		no flags Details | Diff
Patch adding support for the new ${name}_limits mechanics (databases/arangodb33, revision: 1) (2.85 KB, patch)
2018-04-04 18:08 UTC, Mateusz Piotrowski 		no flags Details | Diff
Patch adding support for the new ${name}_limits mechanics (databases/arangodb33, revision: 4) (2.79 KB, patch)
2018-04-11 00:15 UTC, Mateusz Piotrowski 		0mp: maintainer-approval?
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-04-02 23:57:21 UTC 
Created attachment 192135 [details]
Patch adding support for the new ${name}_limits mechanics (databases/arangodb33)

Thanks to the recent change to rc.subr(8) it is no longer necessary to
define a resource limiting logic in service scripts. limits(1) is now run
by default and its configuration is handled via the "${name}_limits"
variable.

Unfortunately, there is a collision of variable names. The service
scripts are broken on FreeBSD version with that new change (12.0-CURRENT,
11-STABLE and soon 11.2-RELEASE). It has been reported and diagnosed here.[2]

I'm submitting a patch fixing the service script for this port. A similar patch
has already been accepted by a maintainer of another database port.[2]

The patch preserves the old behavior on the systems without the
modification.

It would be great if you could review the patch and test it. :)

[1]: https://svnweb.freebsd.org/base?view=revision&revision=r328331
[2]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226907
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2018-04-02 23:57:21 UTC 
Maintainer informed via mail
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-04-04 18:08:22 UTC 
Created attachment 192223 [details]
Patch adding support for the new ${name}_limits mechanics (databases/arangodb33, revision: 1)

The previous patch would fail to trigger the new ${name}_limits semantics for __FreeBSD_version 1101514. The new patch fixes it (thanks to mmokhi@).
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-04-11 00:15:08 UTC 
Created attachment 192410 [details]
Patch adding support for the new ${name}_limits mechanics (databases/arangodb33, revision: 4)

Due to an increasing number of problems caused by the new ${name}_limits behavior, the revision, which was backported from 12-CURRENT to 11-STABLE, has now been reverted.[1] As a result, the new behavior will not be present in any FreeBSD version < 12. 

This new patch adapts the port to those latest changes.

[1]: https://svnweb.freebsd.org/base?view=revision&revision=r332363
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2018-06-09 18:52:49 UTC 
Maintainer timeout
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-06-09 19:26:22 UTC 
A commit references this bug:

Author: riggs
Date: Sat Jun  9 19:25:57 UTC 2018
New revision: 472082
URL: https://svnweb.freebsd.org/changeset/ports/472082

Log:
  Adapt ${name}_limits to the new resource limiting mechanics for services

  While on it:
  - Pet portlint

  PR:		227221
  Submitted by:	0mp
  Approved by:	maintainer timeout

Changes:
  head/databases/arangodb33/Makefile
  head/databases/arangodb33/files/arangod.in