Bug 227224 - databases/mariadb100-server: Adapt ${name}_limits to the new resource limiting mechanics for services
Summary: databases/mariadb100-server: Adapt ${name}_limits to the new resource limitin...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords: regression
Depends on:
Blocks: 227205
  Show dependency treegraph
 
Reported: 2018-04-03 00:23 UTC by Mateusz Piotrowski
Modified: 2018-04-11 00:25 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brnrd)
0mp: maintainer-feedback?


Attachments
Patch adding support for the new ${name}_limits mechanics (databases/mariadb100-server) (3.85 KB, patch)
2018-04-03 00:23 UTC, Mateusz Piotrowski
0mp: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer 2018-04-03 00:23:06 UTC
Created attachment 192139 [details]
Patch adding support for the new ${name}_limits mechanics (databases/mariadb100-server)

Thanks to the recent change to rc.subr(8) it is no longer necessary to
define a resource limiting logic in service scripts. limits(1) is now run
by default and its configuration is handled via the "${name}_limits"
variable.

Unfortunately, there is a collision of variable names. The service
scripts are broken on FreeBSD version with that new change (12.0-CURRENT,
11-STABLE and soon 11.2-RELEASE). It has been reported and diagnosed here.[2]

I'm submitting a patch fixing the service script for this port. A similar patch
has already been accepted by a maintainer of another database port.[2]

The patch preserves the old behavior on the systems without the
modification.

It would be great if you could review the patch and test it. :)

[1]: https://svnweb.freebsd.org/base?view=revision&revision=r328331
[2]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226907
Comment 1 commit-hook freebsd_committer 2018-04-03 19:12:49 UTC
A commit references this bug:

Author: brnrd
Date: Tue Apr  3 19:12:24 UTC 2018
New revision: 466371
URL: https://svnweb.freebsd.org/changeset/ports/466371

Log:
  databases/mariadb100-server: Fix mysql_limits

   - 11-STABLE and 12-CURRENT add limits support to rc.subr(8)
     leading to variable conflicts with rc.d/mysql

  PR:		227224
  Submitted by:	0mp

Changes:
  head/databases/mariadb100-server/Makefile
  head/databases/mariadb100-server/files/mysql-server.in
Comment 2 Bernard Spil freebsd_committer 2018-04-03 19:14:43 UTC
Thank you Mateusz!