Bug 227264 - security/stunnel: Fix build with LibreSSL 2.7
Summary: security/stunnel: Fix build with LibreSSL 2.7
Status: Closed DUPLICATE of bug 224148
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords: needs-qa, patch
Depends on:
Blocks: 226843
  Show dependency treegraph
 
Reported: 2018-04-03 18:02 UTC by Bernard Spil
Modified: 2018-06-09 09:21 UTC (History)
1 user (show)

See Also:
zi: maintainer-feedback-


Attachments
svn diff for security/stunnel (1.17 KB, patch)
2018-04-03 18:02 UTC, Bernard Spil
no flags Details | Diff
svn diff for security/stunnel (2.27 KB, patch)
2018-04-05 19:39 UTC, Bernard Spil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2018-04-03 18:02:12 UTC
Created attachment 192176 [details]
svn diff for security/stunnel

```
security/stunnel: Fix build with LibreSSL 2.7

 - LibreSSL 2.7 implements most of OpenSSL 1.1 API

PR:
Approved by: (maintainer)
```
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2018-04-05 15:09:27 UTC
Isn't this more or less a duplicate of #224148?
Comment 2 Bernard Spil freebsd_committer 2018-04-05 19:39:03 UTC
Created attachment 192256 [details]
svn diff for security/stunnel

Patch was incomplete

I'd say they're not at all the same. There's only one change to the actual code in src/ctx.c for something LibreSSL does not and will not have.
The other patch overwrites the OPENSSL_VERSION_NUMBER that is set by LibreSSL to make stunnel happy.

All in all a far smaller change to the port with far fewer opportunity to cause conflict with stunnel updates.
Comment 3 Ryan Steinmetz freebsd_committer freebsd_triage 2018-04-07 03:33:39 UTC
(In reply to Bernard Spil from comment #2)
Looks like the same sort of patch to me.

Will you guys please update this to use autoconf magic so that we can submit this upstream and have them commit it?
Comment 4 Bernard Spil freebsd_committer 2018-04-07 09:05:14 UTC
From a good while ago. Upstream will not include anything LibreSSL related.

> -------- Original Message --------
> Subject: Re: Patch for stunnel to build with LibreSSL
> Date: 2015-06-02 10:32
> From: Michal Trojnara <Michal.Trojnara@mirt.net>
> To: Bernard Spil <spil.oss@gmail.com>
> 
> Hi Bernard,
> 
> This is a very nice and clean patch indeed.
> I would use it if I ever decided to support LibreSSL.
> 
> Best regards,
> 	Mike

This is the cleanest patch I can create for stunnel. As and when I update security/libressl to 2.7 branch the patch can be further simplified.
I believe this patch is extremely unlikely to cause conflicts on future versions of stunnel and would be happy to fix them if they would.

Cheers, Bernard.
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2018-04-07 12:14:15 UTC
(In reply to Bernard Spil from comment #4)
Which is why I recommended using autoconf to detect the missing functions and have it not directly be related to libressl.

Please see the previous discussion on this in #224148.
Comment 6 Bernard Spil freebsd_committer 2018-06-09 09:21:29 UTC

*** This bug has been marked as a duplicate of bug 224148 ***