Bug 227297 - www/py-django-tables2: update to 1.21.2 and take maintainership (if approved)
Summary: www/py-django-tables2: update to 1.21.2 and take maintainership (if approved)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on: 227295
Blocks: 227416
  Show dependency tree / graph
 
Reported: 2018-04-05 14:41 UTC by Kai Knoblich
Modified: 2018-04-15 19:31 UTC (History)
3 users (show)

See Also:
skozlov: maintainer-feedback+
skozlov: maintainer-feedback+

Attachments
py-django-tables2-1.21.2.patch (1.50 KB, patch)
2018-04-05 14:41 UTC, Kai Knoblich 		skozlov: maintainer-approval+
Details | Diff
py-django-tables2-1.21.1-and-take-maintainership.patch (1.61 KB, patch)
2018-04-05 17:54 UTC, Kai Knoblich 		skozlov: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2018-04-05 14:41:47 UTC 
Created attachment 192245 [details]
py-django-tables2-1.21.2.patch

Hello,

attached is the patch which updates py-django-tables2 to 1.21. This is a major version upgrade compared to the current version in the ports tree.

Changes by upstream (too many, to list them all):
- see https://github.com/jieter/django-tables2/blob/master/CHANGELOG.md

Changes to the port:
- changed from PORTVERSION to DISTVERSION
- changed py-django18 to py-django111 from RUN_DEPENDS
- removed py-six from RUN_DEPENDS (implicit resolved by the py-django111 port)
- added new dependency py-tablib to RUN_DEPENDS (must be committed first, see also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227295)
- sorted USE_PYTHON and NO_ARCH

Note to maintainer:
- I'd like to take maintainership of this port if this is ok for you. The patch still has your e-mail in it just for the case if you want to maintain the port further.

Note to committers:
- the change of the Django dependency from v1.8 to v1.11 should work without problems because there are no ports dependent upon this port at the moment.


QA:
~~~
- poudriere (11.1-RELEASE amd64 + i386) for each py27 + py36 flavor -> OK
- portlint -> OK
Comment 1 Serhii (Sergey) Kozlov freebsd_committer freebsd_triage 2018-04-05 16:52:15 UTC 
Comment on attachment 192245 [details]
py-django-tables2-1.21.2.patch

The patch looks good.
Comment 2 Serhii (Sergey) Kozlov freebsd_committer freebsd_triage 2018-04-05 16:54:33 UTC 
Kai,

Thank you for the patch. I have no problem with you taking the ownership of it. Please go ahead and update the patch to include MAINTAINER change.

Regards,
Sergey
Comment 3 Kai Knoblich freebsd_committer freebsd_triage 2018-04-05 17:54:47 UTC 
Created attachment 192251 [details]
py-django-tables2-1.21.1-and-take-maintainership.patch

Hello Sergey,

thank you very much for your quick reply and approval to let me take maintainership of this port.

I created a new patch with my e-mail address included. Can you please approve that patch to make the transfer of the maintainership official?

Thanks in advance.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-04-15 17:42:31 UTC 
testbuilds@work
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2018-04-15 19:30:54 UTC 
Committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-04-15 19:31:18 UTC 
A commit references this bug:

Author: pi
Date: Sun Apr 15 19:30:44 UTC 2018
New revision: 467407
URL: https://svnweb.freebsd.org/changeset/ports/467407

Log:
  www/py-django-tables2: update 1.2.9 -> 1.21.2

  - submitter becomes maintainer

  PR:		227297
  Submitted by:	Kai <freebsd_ports@k-worx.org>
  Approved:	Sergey Kozlov <kozlov.sergey.404@gmail.com> (maintainer)
  Relnotes:	https://github.com/jieter/django-tables2/blob/master/CHANGELOG.md

Changes:
  head/www/py-django-tables2/Makefile
  head/www/py-django-tables2/distinfo