Bug 227384 - audio/rosegarden: Update to 17.12.1
Summary: audio/rosegarden: Update to 17.12.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adriaan de Groot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-09 05:38 UTC by Yuri Victorovich
Modified: 2018-12-30 16:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adridg)


Attachments
patch (3.95 KB, patch)
2018-04-09 05:38 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2018-04-09 05:38:47 UTC
Created attachment 192354 [details]
patch

Changes:
* Change to DISTVERSION
* Update MASTER_SITES (the previous one doesn't work)
* Add to LIB_DEPENDS
* Make QT5 a default
* Add to QT5_USE
* Add USE_XORG
* Add the patch removing subversion detection

I would also like to suggest to remove QT4, and leave only QT5 permanently enabled. QT4 is an old version, and provides no benefit to users.
Comment 1 Adriaan de Groot freebsd_committer 2018-04-09 08:49:15 UTC
Thanks. I looked at this previously, and ended up stuck because audio/dssi only has a Qt4 version -- but I see now that that's a BUILD_DEPENDS. Disabling the Qt4 UI is a good idea. There's an easier way to suppress subversion detection, although I'd need to look it up (CMAKE_ARGS += -DCMAKE_NO_FIND_Subversion or something like that).
Comment 2 Yuri Victorovich freebsd_committer 2018-04-09 08:59:07 UTC
This library shouldn't be in pkg-plist: lib/librosegardenprivate.so It only installs it in debug mode.
Comment 3 Yuri Victorovich freebsd_committer 2018-04-09 17:04:39 UTC
FYI
This patch is only a version update. Rosegarden crashes a lot in the runtime.

I created this bug report for the upstream: https://sourceforge.net/p/rosegarden/bugs/1559/

But it also crashed for me after I imported some other midi files, and clicked on the midi track. This is probably the upstream bug too.

It also complains about missing fonts. Possibly either some font dependencies are missing or these ports need to be created.
Comment 4 commit-hook freebsd_committer 2018-12-30 15:41:35 UTC
A commit references this bug:

Author: adridg
Date: Sun Dec 30 15:40:48 UTC 2018
New revision: 488721
URL: https://svnweb.freebsd.org/changeset/ports/488721

Log:
  Update audio/rosegarden to 18.12 (latest release).

  Release Notes since 17.04 (previous version in ports):
  	https://rosegardenmusic.com/wiki/dev:17.12
  	https://rosegardenmusic.com/wiki/dev:18.06
  	https://rosegardenmusic.com/wiki/dev:18.12

  Notable is removing Qt4 support, which aligns well with our intentions
  to remove Qt4 from ports. Since Qt5 was the default toolkit already,
  this should have little impact on Rosegarden users.

  Each of the releases had a bunch of bugfixes as well.

  This update supercedes the update in the PR, which bumped to version 17.12.

  PR:		227384
  Reported by:	yuri

Changes:
  head/audio/rosegarden/Makefile
  head/audio/rosegarden/distinfo
  head/audio/rosegarden/pkg-plist
Comment 5 Adriaan de Groot freebsd_committer 2018-12-30 16:55:49 UTC
Committed (well, a successor to this one). Thanks!