Bug 227396 - databases/pecl-redis: Update and split into new port
Summary: databases/pecl-redis: Update and split into new port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-09 19:25 UTC by Daniel Ylitalo
Modified: 2018-04-25 10:35 UTC (History)
1 user (show)

See Also:


Attachments
Patch that updates + splits port (2.45 KB, patch)
2018-04-09 19:25 UTC, Daniel Ylitalo
daniel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ylitalo 2018-04-09 19:25:37 UTC
Created attachment 192367 [details]
Patch that updates + splits port

This update consists of two parts which updates current port and creates a new port with the old version as there are breaking changes in the new version.

First, copy databases/pecl-redis to databases/pecl-redis3
svn cp databases/pecl-redis databases/pecl-redis3

Secondly, apply patch

Both ports passes poudriere testport + portlint -AC after patch.

Changelog:
https://pecl.php.net/package-info.php?package=redis&version=4.0.0
Comment 1 Jochen Neumeister freebsd_committer 2018-04-16 06:48:27 UTC
Hey Daniel :-)

A few questions about this:

why SUBDIR += pecl-redis3? 
The new port is 4.0.0. so pecl-predis4 would not be better with "PKGNAMESUFFIX=4"?


Greetings
Jochen
Comment 2 Daniel Ylitalo 2018-04-16 08:47:36 UTC
Hi Jochen!

If you read through my submission again you will see that it creates a new port and also updates the current one.

Note the "svn cp databases/pecl-redis databases/pecl-redis3" in my submission which is supposed to be run before applying the patch.

both these ports will be present after doing what i wrote in the submission:
databases/pecl-redis (current version)
databases/pecl-redis3 (older version)

This is how other pecl- ports have done it, for example:
pecl-memcached (current version)
pecl-memcached2 (older version)
Comment 3 commit-hook freebsd_committer 2018-04-25 10:34:19 UTC
A commit references this bug:

Author: joneum
Date: Wed Apr 25 10:33:56 UTC 2018
New revision: 468272
URL: https://svnweb.freebsd.org/changeset/ports/468272

Log:
  databases/pecl-redis: Update and split into new port

  This update consists of two parts which updates current port
  and creates a new port with the old version as there are breaking
  changes in the new version.

  PR:		227396
  Submitted by:	Daniel Ylitalo <daniel@blodan.se> (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D15146

Changes:
  head/UPDATING
  head/databases/Makefile
  head/databases/pecl-redis/Makefile
  head/databases/pecl-redis/distinfo
  head/databases/pecl-redis3/
  head/databases/pecl-redis3/Makefile