Bug 227559 - xzgrep missing from base install
Summary: xzgrep missing from base install
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.1-RELEASE
Hardware: Any Any
: Normal Affects Many People
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-16 17:03 UTC by Tom Judge
Modified: 2019-05-23 16:56 UTC (History)
5 users (show)

See Also:
bapt: mfc-stable11?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Judge freebsd_committer 2018-04-16 17:03:13 UTC
It seems r 284345 accidently guarded a bunch of the LZMA variants of grep under MK_BSD_GREP.  This change seems unrelated to the overall changeset of adding META_MODE support. 


https://svnweb.freebsd.org/base/head/usr.bin/grep/Makefile?r1=277939&r2=284345
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-04-18 01:37:09 UTC
Over to committer of r284345.
Comment 2 Kyle Evans freebsd_committer 2018-04-22 00:36:21 UTC
To be honest, I think the fact that we installed bsdgrep as xzgrep WITHOUT_BSD_GREP was a mistake.

If we bring back some of these variants for gnugrep (which we probably should), I would prefer it be done as a script or something that invokes /usr/bin/grep. The behavior between bsdgrep and gnugrep as they currently exist in base has departed quite a bit. I would also like to not weed through bug reports double-checking that they were actually gnugrep and not bsdgrep disguised as xzgrep.
Comment 3 Baptiste Daroussin freebsd_committer 2018-04-25 13:35:22 UTC
This is now addressed by:
https://svnweb.freebsd.org/base?view=revision&revision=332993
Comment 4 ahlam majid 2018-08-20 05:33:26 UTC
I would like to say thanks for including this post. This is very useful information. I bookmarked this site for more references. http://mindsoftglobal.com/pos-software-dubai/