Bug 227627 - graphics/xpdf graphics/xpdf3 graphics/xpdf4: Add xpdf.desktop
Summary: graphics/xpdf graphics/xpdf3 graphics/xpdf4: Add xpdf.desktop
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL:
Keywords: feature, patch
Depends on:
Blocks:
 
Reported: 2018-04-19 01:23 UTC by Mateusz Piotrowski
Modified: 2018-04-20 01:54 UTC (History)
0 users

See Also:
cy: maintainer-feedback+
cy: maintainer-feedback+

Attachments
Patch adding xpdf.desktop files (3.59 KB, patch)
2018-04-19 01:23 UTC, Mateusz Piotrowski 		0mp: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-04-19 01:23:25 UTC 
Created attachment 192635 [details]
Patch adding xpdf.desktop files

Add xpdf.desktop files to both xpdf ports so that it is possible to set xpdf to be the default PDF viewer via xdg-mime.

QA:
 * portlint returns some warnings and fatals but those were there before; I didn't fix them as it could be the case when portlint is wrong
 * poudriere testport xpdf3: 10.4 i386
 * Manual testing of xpdf4 on a FreeBSD 12 running x11/dwm. Setting xpdf as the default PDf application works. I am not sure if it looks good in menus of desktop environments like XFCE.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2018-04-19 01:48:23 UTC 
Approved. Go ahead and commit.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-04-19 09:28:01 UTC 
(In reply to Cy Schubert from comment #1)

Thanks :)

I do not have the commit bit, however, so I cannot do it on my own.
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2018-04-19 12:56:55 UTC 
(In reply to Mateusz Piotrowski from comment #2)
Okay. I'll test it first and commit it.
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2018-04-20 01:54:32 UTC 
Committed. Thanks for the patch.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-04-20 01:54:34 UTC 
A commit references this bug:

Author: cy
Date: Fri Apr 20 01:54:03 UTC 2018
New revision: 467809
URL: https://svnweb.freebsd.org/changeset/ports/467809

Log:
  Add xpdf.desktop files to both xpdf ports so that it is possible to set
  xpdf to be the default PDF viewer via xdg-mime.

  PR:		227627
  Submitted by:	0mp@

Changes:
  head/graphics/xpdf3/Makefile
  head/graphics/xpdf3/files/xpdf.desktop
  head/graphics/xpdf3/pkg-plist
  head/graphics/xpdf4/Makefile
  head/graphics/xpdf4/files/xpdf.desktop
  head/graphics/xpdf4/pkg-plist