Bug 227644 - [maintainer update] for graphics/blender
Summary: [maintainer update] for graphics/blender
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-04-19 19:54 UTC by Shane
Modified: 2018-04-28 12:22 UTC (History)
1 user (show)

See Also:
FreeBSD: maintainer-feedback+


Attachments
maintainer update graphics/blender to 2.79b (11.66 KB, patch)
2018-04-19 19:54 UTC, Shane
FreeBSD: maintainer-approval+
Details | Diff
maintainer update graphics/blender to 2.79b (13.58 KB, patch)
2018-04-27 09:37 UTC, Shane
FreeBSD: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2018-04-19 19:54:35 UTC
Created attachment 192665 [details]
maintainer update graphics/blender to 2.79b

Update graphics/blender to 2.79b
Add Alembic option to include graphics/alembic for import/export options
Modernize cmake options
Add py-numpy as a dependency now that flavours can give us the py35 verion. This is expected to be in place by several addons.
Add USES=compiler:c++14-lang to build using clang50, this fixes the build on 10.4 and is already a dependency through opengl.
Comment 1 Thomas Zander freebsd_committer 2018-04-26 18:53:07 UTC
This does not build on 10.4 i386:

...
In file included from /usr/local/include/Alembic/Abc/All.h:56:
/usr/local/include/Alembic/Abc/ITypedArrayProperty.h:126:29: error: use of overloaded operator '!=' is ambiguous (with operand types 'AbcA::CompoundPropertyReaderPtr' (aka 'shared_ptr<Alembic::AbcCoreAbstract::v10::CompoundPropertyReader>') and 'int')
        ABCA_ASSERT( parent != NULL,
                     ~~~~~~ ^  ~~~~
...
5 errors generated.
[2681/2955] /usr/local/bin/clang++50  -DNDEBUG -DWITH_FREESTYLE -DWITH_INTERNATIONAL -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -D__LITTLE_ENDIAN__ -D__MMX__ -D__SSE2__ -D__SSE__ -isystem /usr/local/include -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/freestyle -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/blenkernel -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/blenlib -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/blentranslation -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/imbuf -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/makesdna -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/makesrna -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/python -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/python/intern -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/render/extern/include -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/render/intern/include -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/extern/glew/include -I/wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/intern/guardedalloc -isystem /usr/local/include/python3.5m -Wall -Wno-tautological-compare -Wno-unknown-pragmas -Wno-char-subscripts -Wno-overloaded-virtual -Wno-sign-compare -Wno-invalid-offsetof -O2 -pipe -fstack-protector -fno-strict-aliasing -march=i586  -march=i586   -msse -pipe -fPIC -funsigned-char -fno-strict-aliasing -msse2 -O2 -pipe -fstack-protector -fno-strict-aliasing -march=i586  -march=i586 -MD -MT source/blender/freestyle/CMakeFiles/bf_freestyle.dir/intern/view_map/ViewMapBuilder.cpp.o -MF source/blender/freestyle/CMakeFiles/bf_freestyle.dir/intern/view_map/ViewMapBuilder.cpp.o.d -o source/blender/freestyle/CMakeFiles/bf_freestyle.dir/intern/view_map/ViewMapBuilder.cpp.o -c /wrkdirs/usr/ports/graphics/blender/work/blender-2.79b/source/blender/freestyle/intern/view_map/ViewMapBuilder.cpp
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.
Comment 2 Thomas Zander freebsd_committer 2018-04-27 05:36:39 UTC
Do you plan to add a DOCS option?
portlint output:
FATAL: Makefile: PORTDOCS appears in plist but DOCS is not listed in OPTIONS_DEFINE.
Comment 3 Shane 2018-04-27 09:37:40 UTC
Created attachment 192841 [details]
maintainer update graphics/blender to 2.79b

Always enable WITH_CXX11 as it is now needed to build several options.
Remove PORTDOCS from pkg-plist. This has been in place for several years but there has been no code to alter the install based on a docs option.
Update LICENSE to GPLv3+ as there are several palces containing GPL3 code.

There is a man page and a readme installed along with nine license files, as the license files should always be installed, I don't see any benefit to altering the installed files to remove a readme of about 6k in a project this large.
Comment 4 Shane 2018-04-27 09:42:29 UTC
(In reply to Thomas Zander from comment #1)
Enabling c++11 fixes the alembic build. I didn't see this before as it has been a while since I have tested with various option combinations, by enabling CYCLESOSL the WITH_CXX11 option was always turned on.
Comment 5 commit-hook freebsd_committer 2018-04-28 12:19:35 UTC
A commit references this bug:

Author: riggs
Date: Sat Apr 28 12:19:24 UTC 2018
New revision: 468539
URL: https://svnweb.freebsd.org/changeset/ports/468539

Log:
  Update to upstream version 2.79b

  Detailed maintainer log:
  - Update graphics/blender to 2.79b
  - Add Alembic option to include graphics/alembic for import/export options
  - Modernize cmake options
  - Add py-numpy as a dependency now that flavours can give us the py35
    version. This is expected to be in place by several addons.
  - Add USES=compiler:c++14-lang to build using clang50, this fixes the
    build on 10.4 and is already a dependency through opengl.

  PR:		227644
  Submitted by:	FreeBSD@ShaneWare.Biz (maintainer)

Changes:
  head/graphics/blender/Makefile
  head/graphics/blender/Makefile.options
  head/graphics/blender/Makefile.versions
  head/graphics/blender/distinfo
  head/graphics/blender/files/patch-intern_cycles_CMakeLists.txt
  head/graphics/blender/pkg-plist