Bug 227858 - audio/pms-devel: some fixes (patch).
Summary: audio/pms-devel: some fixes (patch).
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-04-29 19:41 UTC by Alexandre C. Guimarães
Modified: 2018-04-30 13:43 UTC (History)
0 users

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly+


Attachments
Some fixes. (1.62 KB, patch)
2018-04-29 19:41 UTC, Alexandre C. Guimarães
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre C. Guimarães freebsd_committer 2018-04-29 19:41:35 UTC
Created attachment 192920 [details]
Some fixes.

Hi.

Attached a patch to

- fix documentation being installed weirdly (replication of $PREFIX path inside $DOCSDIR)
- switch to DISTVERSION
- switch version number to use the format used for GITHUB when upstream does not use a version number (gYYYYMMDD)
- set PORTEPOCH due to the version format change.

Thanks! :)
Comment 1 commit-hook freebsd_committer 2018-04-30 13:34:50 UTC
A commit references this bug:

Author: riggs
Date: Mon Apr 30 13:34:38 UTC 2018
New revision: 468700
URL: https://svnweb.freebsd.org/changeset/ports/468700

Log:
  Fix install path for DOCS

  PR:		227858
  Reported by:	lebarondemerde@privacychain.ch
  MFH:		2018Q2

Changes:
  head/audio/pms-devel/Makefile
Comment 2 commit-hook freebsd_committer 2018-04-30 13:36:54 UTC
A commit references this bug:

Author: riggs
Date: Mon Apr 30 13:35:52 UTC 2018
New revision: 468701
URL: https://svnweb.freebsd.org/changeset/ports/468701

Log:
  MFH: r468700

  Fix install path for DOCS

  PR:		227858
  Reported by:	lebarondemerde@privacychain.ch

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2018Q2/
  branches/2018Q2/audio/pms-devel/Makefile
Comment 3 Thomas Zander freebsd_committer 2018-04-30 13:43:14 UTC
Thanks for the patch!

I imported the DOCS part but left out the parts dealing with the version numbering scheme, here's why:
PORTEPOCH is really a last-resort kind of thing in case the upstream project screws up versioning at some point in time. Most importantly, once introduced we don't get rid of it, ever! Thus, I will stick with the current scheme until upstream decides on version numbering.