When ADNS is configured in, or even when just adns.h is present build is broken: source='log.cc' object='log.o' libtool=no depfile='.deps/log.Po' tmpdepfile='.deps/log.TPo' depmode=gcc3 /bin/sh ../config/depcomp c++ -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include -I /usr/local/include -O2 -pipe -fstack-protector -fno-strict-aliasing -c -o log.o `test -f log.cc || echo './'`log.cc In file included from log.cc:3: ... [lots of warnings] ... log.cc:75:8: error: C-style cast from 'nullptr_t' to 'adns_queryflags' is not allowed (adns_queryflags) NULL, NULL, b->dns_query); ^~~~~~~~~~~~~~~~~~~~~~ ... [more warnings] ... 10 warnings and 1 error generated. *** Error code 1 Stop. The following makes the compiler go ahead: diff -c log.cc log.cc-fixed *** log.cc Mon Apr 30 09:12:55 2018 --- log.cc-fixed Mon Apr 30 09:22:22 2018 *************** *** 72,78 **** /* fire off a query with adns */ b->dns_query = new adns_query; adns_submit(adns, ptr, adns_r_a, ! (adns_queryflags) NULL, NULL, b->dns_query); b->ip_pos = im->insert(RESOLVING_STRING); b->ip_hash = TTHash(RESOLVING_STRING); --- 72,78 ---- /* fire off a query with adns */ b->dns_query = new adns_query; adns_submit(adns, ptr, adns_r_a, ! (adns_queryflags) 0, NULL, b->dns_query); b->ip_pos = im->insert(RESOLVING_STRING); b->ip_hash = TTHash(RESOLVING_STRING);
*** Bug 230737 has been marked as a duplicate of this bug. ***
Created attachment 196553 [details] Fixes compile
(In reply to Nathan from comment #2) Per our IRC conversation, the existing port patches were added *in favour* of and *instead* of using -cxxstd [1]. *if* CXXSTD is going to be used, the existing patches that fix those errors should removed, OR, the rest of the sources should be patched so that the cxxstd is not required, as provided in comment 0, and should be sent upstream. [1] ports r460880
See bug 225649 comment 2
(In reply to Kubilay Kocak from comment #4) Weird I thought I deleted them but will take care of
Created attachment 196595 [details] Removed patches and fixes build
There's also a typo (PCRE_CO*FN*IGURE), however, I don't see why we would fallback to C++98 rather than fix the sloppy code and push the changes upstream.
(In reply to Alexey Dokuchaev from comment #7) I am no programmer but got it fixed without the cxx98
Created attachment 196637 [details] Fix compile; Fix mis-spelled word
(In reply to Alexey Dokuchaev from comment #7) There is no active upstream, at least the original one. I think that apachetop is now developed here: https://github.com/tessus/apachetop/ and contains some fixes and improvements. I'll test it and prepare update of this port.
(In reply to Lukasz Wasikowski from comment #10) Just uploaded new patch with fixes
(In reply to Nathan from comment #11) Great, thank you.
Comment on attachment 196637 [details] Fix compile; Fix mis-spelled word It looks good, please commit it.
Committed, thanks!
A commit references this bug: Author: pi Date: Tue Dec 18 22:03:44 UTC 2018 New revision: 487774 URL: https://svnweb.freebsd.org/changeset/ports/487774 Log: sysutils/apachetop: update 0.12.6 -> 0.18.4 - moved to github - Fix compile - Fix mis-spelled word PR: 227865 Submitted by: ndowens@yahoo.com Reported by: Thomas-Henning von Kamptz <tomsoft@mac.com> Reviewed by: koobs, danfe Approved by: Lukasz Wasikowski <lukasz@wasikowski.net> (maintainer) Changes: head/sysutils/apachetop/Makefile head/sysutils/apachetop/distinfo head/sysutils/apachetop/files/patch-apachetop.h head/sysutils/apachetop/files/patch-resolver.h head/sysutils/apachetop/files/patch-src_apachetop.cc head/sysutils/apachetop/files/patch-src_display.cc head/sysutils/apachetop/files/patch-src_hits__circle.cc head/sysutils/apachetop/files/patch-src_inlines.cc head/sysutils/apachetop/files/patch-src_log.cc head/sysutils/apachetop/files/patch-src_ohtbl.cc head/sysutils/apachetop/pkg-descr