Bug 227973 - /usr/doc fails to update when WITH_SVN= is specified
Summary: /usr/doc fails to update when WITH_SVN= is specified
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sevan Janiyan
URL: https://reviews.freebsd.org/D16695
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2018-05-04 16:56 UTC by Dries Michiels
Modified: 2018-08-12 10:14 UTC (History)
1 user (show)

See Also:


Attachments
Patch to fix "make update" when WITH_SVN= is specified (308 bytes, patch)
2018-05-04 16:56 UTC, Dries Michiels
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels 2018-05-04 16:56:10 UTC
Created attachment 193045 [details]
Patch to fix "make update" when WITH_SVN= is specified

/usr/doc fails to update when WITH_SVN= is used to build from source.
The makefile checks either the existence of the svn command of the package or svnlite but not for /usr/bin/svn.

This causes the following error when issuing "make update":

--------------------------------------------------------------
>>> /usr/local/bin/svn is required to update /usr/doc
--------------------------------------------------------------
Comment 1 commit-hook freebsd_committer 2018-08-12 10:13:38 UTC
A commit references this bug:

Author: sevan
Date: Sun Aug 12 10:12:51 UTC 2018
New revision: 52119
URL: https://svnweb.freebsd.org/changeset/doc/52119

Log:
  Handle building on systems utilising WITH_SVN knob.

  PR:		227973
  Submitted by:	Dries Michiels <dries.michiels at gmail>
  Approved by:	bcr (mentor)
  Sponsored by:	Essen Hackathon
  Differential Revision:	https://reviews.freebsd.org/D16695

Changes:
  head/Makefile
Comment 2 Sevan Janiyan freebsd_committer 2018-08-12 10:14:17 UTC
Committed, thanks!