Bug 228005 - bsdinstall's zfsboot step should run nvmecontrol to identify NVMe drives
Summary: bsdinstall's zfsboot step should run nvmecontrol to identify NVMe drives
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-sysinstall (Nobody)
URL:
Keywords: feature, install
Depends on:
Blocks:
 
Reported: 2018-05-06 04:02 UTC by Rebecca Cran
Modified: 2023-10-15 13:27 UTC (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Cran freebsd_committer freebsd_triage 2018-05-06 04:02:16 UTC 
Currently, during installation the disk/partition management section runs camcontrol to show identification data to the user. It would be nice if it also ran nvmecontrol, since NVMe drives are increasingly being used as an install target.
Comment 1 Nathan Whitehorn freebsd_committer freebsd_triage 2018-05-06 22:21:45 UTC 
I've renamed it since the main partitioner (the UFS one and single-volume ZFS one) doesn't use either and gets the names from geom directly, which always works. It would be good if the zfsboot partition either did the same thing or, maybe better, got rolled into the "partedit" tool.
Comment 2 Rebecca Cran freebsd_committer freebsd_triage 2018-05-06 23:23:27 UTC 
Oh, so it does.

The zfsboot script only calls camcontrol if the user selects the option to "Get detailed information on disk device(s)" - at which point it runs "gpart show", "camcontrol inquiry" and "camcontrol identity".
Comment 3 Graham Perrin 2023-10-15 13:27:56 UTC 
NB <https://www.freebsd.org/releases/14.0R/> the release note about NVMe.

^Triage: 

* status
* severity reduced, to the norm for a feature request.