Bug 228102 - Patch multimedia/motion Makefile to use webcamd without building multimedia/pwcbsd
Summary: Patch multimedia/motion Makefile to use webcamd without building multimedia/p...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 16:57 UTC by Curtis Villamizar
Modified: 2018-05-15 14:27 UTC (History)
2 users (show)

See Also:


Attachments
patch multimedia/motion/Makefile to add WEBCAMD option (1021 bytes, patch)
2018-05-09 16:57 UTC, Curtis Villamizar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Villamizar 2018-05-09 16:57:17 UTC
Created attachment 193216 [details]
patch multimedia/motion/Makefile to add WEBCAMD option

The multimedia/pwcbsd port contains an kernel module that appears to no longer work.  The multimedia/pwcbsd port distfile has not been updated since 2014 so it is very unlikely to work.  The multimedia/pwcbsd port was long ago replaced by the multimedia/webcamd port.

The current multimedia/motion port has a PWCBSD option.  This sets --with-pwcbsd in the configure step, create a build depend on v4l_compat and creates a run depend on multimedia/pwcbsd, which is then built and installed but not used.  The motion application reads from /dev/video* which is now handled by multimedia/webcamd.

The patch provided adds an option named WEBCAMD to an existing radio option that contains the PWCBSD option.  The WEBCAMD option sets --with-pwcbsd in the configure step, creates the build depend on v4l_compat but does not create a run depend on pwcbsd.  It could create a run depend on multimedia/webcamd but I didn't add that.

The only affect of --with-pwcbsd in the configure step of the downstream port is to suppress disabling video4linux support and link with v4l_compat library.  At some point the downstream should be advised to change the option names in the configure.ac file to reflect the demise of pwcbsd.

I left the PWCBSD option in place and unchanged.  It may serve no useful purpose so it could be removed.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-05-15 14:25:56 UTC
A commit references this bug:

Author: lme
Date: Tue May 15 14:25:40 UTC 2018
New revision: 470020
URL: https://svnweb.freebsd.org/changeset/ports/470020

Log:
  multimedia/motion:

  - Add WEBCAMD option and enable by default
  - Bump PORTREVISION

  From the initiating PR:

  The multimedia/pwcbsd port contains an kernel module that appears to no longer
  work.  The multimedia/pwcbsd port distfile has not been updated since 2014 so
  it is very unlikely to work.  The multimedia/pwcbsd port was long ago replaced
  by the multimedia/webcamd port.

  The current multimedia/motion port has a PWCBSD option.  This sets
  --with-pwcbsd in the configure step, create a build depend on v4l_compat and
  creates a run depend on multimedia/pwcbsd, which is then built and installed
  but not used.  The motion application reads from /dev/video* which is now
  handled by multimedia/webcamd.

  The patch provided adds an option named WEBCAMD to an existing radio option
  that contains the PWCBSD option.  The WEBCAMD option sets --with-pwcbsd in the
  configure step, creates the build depend on v4l_compat but does not create a
  run depend on pwcbsd.  It could create a run depend on multimedia/webcamd but I
  didn't add that.

  The only affect of --with-pwcbsd in the configure step of the downstream port
  is to suppress disabling video4linux support and link with v4l_compat library.
  At some point the downstream should be advised to change the option names in
  the configure.ac file to reflect the demise of pwcbsd.

  I left the PWCBSD option in place and unchanged.  It may serve no useful
  purpose so it could be removed.

  PR:		228102
  Submitted by:	Curtis Villamizar <curtis@ipv6.occnc.com>
  MFH:		yes

Changes:
  head/multimedia/motion/Makefile
Comment 2 Lars Engels freebsd_committer freebsd_triage 2018-05-15 14:27:08 UTC
Thanks a lot for the patch, good work!