Bug 228203 - ports-mgmt/portlint: regression re "make makepatch"
Summary: ports-mgmt/portlint: regression re "make makepatch"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-12 20:19 UTC by Gerald Pfeifer
Modified: 2018-05-12 23:22 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer 2018-05-12 20:19:57 UTC
PR 202050 was addressed by a patch of mine and marked Closed FIXED on
2015-08-09.

With portlint 2.18.0 this returned, and the line I had added is commented
as follows:

                          #                       last;

So probably this was done for debugging purposes and missed when releasing?


Also, the workaround in patchfiles to avoid this warning no longer works.
For a testcase for both issues, "cd $PORTSDIR/lang/gcc8-devel ; portlint -C".
Comment 1 Joe Marcus Clarke freebsd_committer 2018-05-12 21:02:11 UTC
The last was bad.  It broke all of the other checks for the patch.  So, either the whole patch needs to be read, and then a separate loop is needed for this check or the last needs to be left out.
Comment 2 Joe Marcus Clarke freebsd_committer 2018-05-12 22:14:45 UTC
Fixed in 2.18.2.
Comment 3 commit-hook freebsd_committer 2018-05-12 22:15:16 UTC
A commit references this bug:

Author: marcus
Date: Sat May 12 22:14:31 UTC 2018
New revision: 469758
URL: https://svnweb.freebsd.org/changeset/ports/469758

Log:
  Bump version to 2.18.2.

  Fix a regression in the mae makepatch check.

  Make sure only the patch header is checked, but make sure
  to read in the entire patch file.  This regression was
  introduced in 2.18.0.

  PR:		228203

Changes:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.pl
Comment 4 Gerald Pfeifer freebsd_committer 2018-05-12 23:22:36 UTC
Super - thanks for the ultra-fast response! 

Happy to confirm this fixes both issues I've seen/reported.