Bug 228212 - security/axTLS: Drop WITH_HTTP_PORT
Summary: security/axTLS: Drop WITH_HTTP_PORT
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-05-13 09:02 UTC by Bernard Spil
Modified: 2019-01-17 15:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (umq)


Attachments
svn diff for security/axTLS (769 bytes, patch)
2018-05-13 09:02 UTC, Bernard Spil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2018-05-13 09:02:03 UTC
Created attachment 193347 [details]
svn diff for security/axTLS

The only ports using WITH_HTTP_PORT (and WITH_HTTPS_PORT) are www/apache24 and security/axTLS. The removal of WITH_HTTP_PORT from www/apache24 is pending review https://reviews.freebsd.org/D15411 but I didn't find the maintainer of axTLS in the user list there.

Looking at the axTLS port (also after configure), I don't see any use of WITH_HTTP_PORT or WITH_HTTPS_PORT in the code or in configure. 
The use of CONFIG_SUB is also a mystery to me, I don't find references to it in Mk/* or in the porter's handbook, it should probably be removed completely?

Please find a patch for the removal of WITH_HTTP_PORT and WITH_HTTPS_PORT attached. I'll follow up with a review on Phabricator with changes to Mk/bsd.sanity.mk
Comment 1 Tobias Kortkamp freebsd_committer 2019-01-17 15:13:57 UTC
I do not think this patch is valid as is.  CONFIG_SUB is just a custom
variable use to create _CONFIG_SUB_TMP which in turn is used in do-configure
to substitute some values (including HTTP_PORT and SSL_PORT derived from
the WITH_HTTP_PORT and WITH_SSL_PORT knobs) in files/data-.config.in to
create ${WRKSRC}/config/.config for the build.  So the values of 
WITH_{SSL,HTTP}_PORT are definitely used.

So I think it would be better to rename WITH_{SSL,HTTP}_PORT in this port
to something else instead.