Bug 228325 - bsdinstall.8: Use sysrc(8) in the example script in bsdinstall.8
Summary: bsdinstall.8: Use sysrc(8) in the example script in bsdinstall.8
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-sysinstall (Nobody)
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2018-05-17 21:16 UTC by Mateusz Piotrowski
Modified: 2018-05-19 14:25 UTC (History)
1 user (show)

See Also:

Attachments
Patch replacing echo with sysrc in the example script in bsdinstall.8 (435 bytes, patch)
2018-05-17 21:16 UTC, Mateusz Piotrowski 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-05-17 21:16:44 UTC 
Created attachment 193499 [details]
Patch replacing echo with sysrc in the example script in bsdinstall.8

Now that we have sysrc(8) I thought that we might encourage people to use it instead of echo to modify system rc files. 

Hence this patch replacing echo with sysrc in the script example.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-05-18 17:47:29 UTC 
A commit references this bug:

Author: nwhitehorn
Date: Fri May 18 17:46:40 UTC 2018
New revision: 333804
URL: https://svnweb.freebsd.org/changeset/base/333804

Log:
  Use sysrc(8) in the documentation rather than echoing things to rc.conf
  in order to encourage good habits.

  PR:		228325
  Submitted by:	Mateusz Piotrowski
  MFC after:	2 weeks

Changes:
  head/usr.sbin/bsdinstall/bsdinstall.8