Bug 228350 - devel/rubygem-fugit: fails to build with Ruby 2.5
Summary: devel/rubygem-fugit: fails to build with Ruby 2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-18 18:25 UTC by Piotr Kubaj
Modified: 2018-07-28 13:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-05-18 18:25:59 UTC 
This port builds with Ruby 2.4, but with 2.5 it throws error:
===>   Generating temporary packing list
(cd /var/ports/devel/rubygem-fugit/work/fugit-1.1.1; /usr/bin/env RB_USER_INSTALL=yes LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 /usr/local/bin/gem25 install -l --no-update-sources --install-dir /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5 --ignore-dependencies --bindir=/var/ports/devel/rubygem-fugit/work/stage/usr/local/bin --rdoc --ri fugit-1.1.1.gem -- --build-args )
Successfully installed fugit-1.1.1
Parsing documentation for fugit-1.1.1
Installing ri documentation for fugit-1.1.1
Installing darkfish documentation for fugit-1.1.1
ERROR:  While executing gem ... (RDoc::Error)
    error generating Fugit/Cron/Parser.html: no implicit conversion of nil into String (TypeError)
*** Error code 1

Stop.
make[1]: stopped in /var/ports/devel/rubygem-fugit
*** Error code 1

Running make again works:
===>   Generating temporary packing list
(cd /var/ports/devel/rubygem-fugit/work/fugit-1.1.1; /usr/bin/env RB_USER_INSTALL=yes LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 /usr/local/bin/gem25 install -l --no-update-sources --install-dir /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5 --ignore-dependencies --bindir=/var/ports/devel/rubygem-fugit/work/stage/usr/local/bin --rdoc --ri fugit-1.1.1.gem -- --build-args )
Successfully installed fugit-1.1.1
Parsing documentation for fugit-1.1.1
Done installing documentation for fugit after 1 seconds
1 gem installed
/bin/rm -f -r /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5/build_info/
/usr/bin/find /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5 -type f -name '*.so' -exec /usr/bin/strip {} +
/usr/bin/find /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5 -type f \( -name mkmf.log -or -name gem_make.out \) -delete
/bin/rm -f -r /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5/gems/fugit-1.1.1/ext  /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5/cache 2> /dev/null || true
/bin/rmdir /var/ports/devel/rubygem-fugit/work/stage/usr/local/lib/ruby/gems/2.5/extensions 2> /dev/null || true
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)

But that is not possible with Poudriere.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-06-20 16:55:04 UTC 
Ruby 2.5 uses rdoc 6. I'll turn off rdoc generation to avoid this problem.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-07-28 13:18:52 UTC 
A commit references this bug:

Author: sunpoet
Date: Sat Jul 28 13:17:52 UTC 2018
New revision: 475569
URL: https://svnweb.freebsd.org/changeset/ports/475569

Log:
  Disable rdoc generation

  PR:		228350
  Reported by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/devel/rubygem-fugit/Makefile
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-07-28 13:19:30 UTC 
Committed. Thanks!