Bug 228395 - ports-mgmt/porttools: Should probably insert DISTVERSION instead of PORTVERSION
Summary: ports-mgmt/porttools: Should probably insert DISTVERSION instead of PORTVERSION
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Walter Schwarzenfeld
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-21 12:38 UTC by Jason W. Bacon
Modified: 2019-08-15 04:15 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (skreuzer)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer 2018-05-21 12:38:42 UTC
The Porter's Handbook (and my mentors) state that DISTVERSION should be used instead of PORTVERSION whenever possible (section 5.2.2):

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html

The "port create" command currently inserts PORTVERSION into new skeletal ports, though.

Should just be a matter of updating tmpl/*.
Comment 1 Chris Hutchinson 2018-05-21 16:43:45 UTC
(In reply to Jason W. Bacon from comment #0)
> The Porter's Handbook (and my mentors) state that DISTVERSION should be used
> instead of PORTVERSION whenever possible (section 5.2.2):
> 
> https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-
> naming.html
> 
> The "port create" command currently inserts PORTVERSION into new skeletal
> ports, though.
> 
> Should just be a matter of updating tmpl/*.

Not (necessarily) complaining here. But; when did $DISTVERSION
become the defacto?
When I became a Maintainer some 4½ yrs ago, $PORTVERSION was
"it".

Thanks

--Chris
Comment 2 Jason W. Bacon freebsd_committer 2018-05-21 18:39:21 UTC
I think it was fairly recent.  I was using PORTVERSION with nobody complaining for years, but started getting dinged for it maybe the past 4 or 5 months.
Comment 3 Chris Hutchinson 2018-05-21 18:47:53 UTC
(In reply to Jason W. Bacon from comment #2)
> I think it was fairly recent.  I was using PORTVERSION with nobody
> complaining for years, but started getting dinged for it maybe the past 4 or
> 5 months.

Grr...
If that true; look for some ~150 pr(1)'s headed to bugzilla.
Cause that's about how many I'm currently maintaining, and
I'll want to handle it in one giant batch to get it
over with.

Sigh...


Thanks for taking the time to reply, Jason!

--Chris
Comment 4 Walter Schwarzenfeld freebsd_triage 2019-08-14 23:10:08 UTC
Can we close here? Or still anything to discuss?
Comment 5 Jason W. Bacon freebsd_committer 2019-08-15 00:20:54 UTC
Never did hear from the maintainer.  I'm OK with closing as it's an easy issue to work around.