Bug 228479 - www/palemoon: Consolidate sndio patches and apply softvol fix
Summary: www/palemoon: Consolidate sndio patches and apply softvol fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-05-25 08:58 UTC by Tobias Kortkamp
Modified: 2018-05-25 13:14 UTC (History)
1 user (show)

See Also:
lichray: maintainer-feedback+


Attachments
palemoon.diff (9.07 KB, patch)
2018-05-25 08:58 UTC, Tobias Kortkamp
lichray: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2018-05-25 08:58:15 UTC
Created attachment 193680 [details]
palemoon.diff

Hi,

this consolidates all sndio patches into one and adds the softvol fix
from [1]. This will prevent Pale Moon from changing the slot volumes of
sndiod which can lead to them being too silent or even muted when Pale
Moon happens to reuse one of them later.

Thanks!

[1] https://marc.info/?l=openbsd-ports&m=152641946326955&w=2

Builds fine in Poudriere on 12.0-CURRENT/amd64.
Comment 1 lichray 2018-05-25 13:00:06 UTC
Nice.
Comment 2 commit-hook freebsd_committer 2018-05-25 13:10:09 UTC
A commit references this bug:

Author: tobik
Date: Fri May 25 13:09:11 UTC 2018
New revision: 470834
URL: https://svnweb.freebsd.org/changeset/ports/470834

Log:
  www/palemoon: Consolidate sndio patches and apply softvol fix [1]

  This will prevent Pale Moon from changing the slot volumes of sndiod
  which can lead to them being too silent or even muted when Pale Moon
  happens to reuse one of them later.  It'll also fix a bug where Pale
  Moon won't pick up slot volumes changes done externally and thus
  provides inaccurate volume controls.

  [1] https://marc.info/?l=openbsd-ports&m=152641946326955&w=2

  PR:		228479
  Submitted by:	tobik
  Approved by:	lichray@gmail.com (maintainer)

Changes:
  head/www/palemoon/Makefile
  head/www/palemoon/files/patch-bug1153151
  head/www/palemoon/files/patch-bug1153179
  head/www/palemoon/files/patch-cubeb5ffce9e91b
  head/www/palemoon/files/patch-sndio
Comment 3 Tobias Kortkamp freebsd_committer 2018-05-25 13:14:36 UTC
Thanks!